-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Writing x y z grids? #3057
Comments
It could certainly be added, but I would not see to point. I would even be in favor of removing If you want |
Yes, I want to have I can always try to work out how to dump @mikekryjak @johnomotani FYI in case you have an opinion on this topic. |
I guess it boils down to what balance you want to strike between ease of post-processing / minimising mistakes and keeping the output files slim. I guess I am always going to be strongly biased towards the former, because A) I am used to CFD software which does this, B) I haven't lived through the pain of 3D turbulence modelling, and C) I have spent endless weeks getting confused with things like normalisation and reconstructing things in post-processing. This includes the grid reconstruction stuff which is simple in principle but has a few gotchas that make mistakes easy.... it has cost me probably over two weeks of wasted time in total across SD1D and Hermes-3 1D and 2D. In Hermes-3 we do have the radial, poloidal and toroidal lengths calculated in post-processing and the user doesn't have to do any further reconstruction apart from calculating the parallel connection length, so in principle we are not in a bad place. I am close to having all of the relevant lengths/etc calculated in xHermes. Now when it comes to what's available in the code, not having lengths is a problem for 1D where it is convenient to supply profiles of magnetic field or sources as a function of Lpar. We have a PR that resolves this by doing the Lpar reconstruction within the code and adding it to the state for this purpose: bendudson/hermes-3#232 |
I am looking at making a manufactured solutions test in a geometry where is is more convenient to work directly with some
x
y
z
coordinates and metric coefficients that are specified from theBOUT.inp
file. The output netcdf file from BOUT does not appear to write thex
y
z
grids out, but instead only writesdx
dy
dz
. Is there a fundamental reason for this? Could the grids be added to the output?The text was updated successfully, but these errors were encountered: