Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose role in Button component #2433

Open
coderitual opened this issue Jun 10, 2022 · 2 comments
Open

Expose role in Button component #2433

coderitual opened this issue Jun 10, 2022 · 2 comments
Assignees
@clxandstuff
Labels
Type: A11Y Type: Discussion Type: Enhancement

Comments

@coderitual
Copy link
Contributor

coderitual commented Jun 10, 2022 •
edited
Loading

The idea is to expose role in button component to sometimes treat button only as a presentational element. I would say it's just a reason to start the discussion and maybe explore other solutions for this specific case.

image

Reference:
@coderitual coderitual changed the title Expose role in <Button/> component Expose role in Button component Jun 10, 2022
@clxandstuff
Copy link
Contributor

You can use role prop, because we are passing rest props of type React.AllHTMLAttributes<HTMLElement> to button element.

@clxandstuff clxandstuff self-assigned this Mar 22, 2023
@coderitual
Copy link
Contributor Author

Yea true, I guess I meant expose it explicitly with documentation and examples. Sorry for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clxandstuff clxandstuff

Labels
Type: A11Y Type: Discussion Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coderitual @clxandstuff