Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluent interface in MapOptions #208

Open
povilasb opened this issue Jun 1, 2014 · 3 comments
Open

Fluent interface in MapOptions #208

povilasb opened this issue Jun 1, 2014 · 3 comments

Comments

@povilasb
Copy link

povilasb commented Jun 1, 2014

It would be nice if MapOptions implemented the Fluent Interface pattern.

e.g.

MapOptions options = MapOptions.newInstance().setCenter(...).setZoom(...);
@twistedpair
Copy link
Collaborator

@povilasb

Good point. This could be done without breaking changes, I believe, since presently the methods are void, so no one is doing anything with their return values.

I'm strapped for time at the moment, but if you've got the time to update the class, mostly just updating the method signatures and adding return this;, we'd be grateful and happy to merge it.

@branflake2267
Copy link
Owner

A Builder (pattern) sub type could be added as a subclass.

@twistedpair
Copy link
Collaborator

@branflake2267 good point and perhaps a more self contained solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants