Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect popup is not dismissed when opening a new tab from home screen #43167

Closed
2 of 6 tasks
srirambv opened this issue Jan 8, 2025 · 0 comments · Fixed by brave/brave-core#27249
Closed
2 of 6 tasks

Connect popup is not dismissed when opening a new tab from home screen #43167

srirambv opened this issue Jan 8, 2025 · 0 comments · Fixed by brave/brave-core#27249
Assignees
@simoarpe
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA/Yes release-notes/include
Milestone
1.76.x - Nightly

Comments

@srirambv
Copy link
Contributor

srirambv commented Jan 8, 2025 •
edited
Loading

Description

Connect popup is not dismissed when opening a new tab from home screen

Steps to reproduce

  1. Visit the PoC link
  2. Background the app
  3. Long press on icon and select New Tab
  4. Continues to show the connect popup message

Actual result

Recording in comment

Expected result

Should not show connect pop up if new tab is loaded

Reproduces how often

Easily reproduced

Brave version

1.73.105

Device

  • Brand/model: Pixel 8
  • Android version: 15

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc: @simoarpe @vadimstruts
@srirambv srirambv added bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA/Yes release-notes/include labels Jan 8, 2025
@srirambv srirambv added this to Web3 Jan 8, 2025
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Jan 13, 2025
@simoarpe simoarpe self-assigned this Jan 15, 2025
@simoarpe simoarpe moved this from Backlog to In Progress in Web3 Jan 15, 2025
@simoarpe simoarpe mentioned this issue Jan 15, 2025
Merged
24 tasks
@simoarpe simoarpe moved this from In Progress to In Review in Web3 Jan 15, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jan 15, 2025
@brave-builds brave-builds added this to the 1.76.x - Nightly milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simoarpe simoarpe

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA/Yes release-notes/include
Projects
Web3
Status: Done
Milestone
1.76.x - Nightly
Development

Successfully merging a pull request may close this issue.

(Wallet) Fix Dapps dialog not dismissed when creating a new tab brave/brave-core
3 participants
@simoarpe @srirambv @brave-builds