-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom content filters don't work #43179
Comments
May also affect iOS. https://community.brave.com/t/blocking-youtube-home-feed-on-mobile/588732/4 |
If you want to block the document and get the interstitial page, you need to have the Adblocker in Aggressive mode, Standard doesn't do that even for Custom Adblock rules, even if they are not subject to the Aggressive vs Standard mode. If not, you are just will just blocking any Type being downloaded from the URL that matches your rule, in this case So if you add But if it is the document as I understand based on your rules, then only Aggressive mode blocks documents either I don't know about iOS though, but iOS is not Chromium, but I guess it has the interstitial page, but no way I can test it. Of course, I wouldn't trust the people in that Community Brave thread either, because people are mostly clueless about how adblockers work and how to make proper rules, etc. |
Thanks for the reply!
Why? Where is that documented? Why doesn't it just respect my filters? Doesn't enabling aggressive mode have other side effects? |
Confirming it works in aggressive mode, thanks! |
Just to avoid confusion for non-tech people, if people are decent with technology they will enable the Aggressive mode and get the screen, if not, the standard is meant to be able to block the real tracking third-party, and some some first party and then don't cause too many issues or breakages or confusion for users, especially if they are not tech people. Brave is the only adblocker that has the two modes, so it's a new concept of blocking and trying to reduce issues since 1p tracking can be reduced but not eliminated since you are sharing IPs with their servers and headers and too much info once you visit _their domain. You can read this was discussed 2 years ago #28388 (comment), issue is still opened so might happen or not, but one reason is like you click on a link and it will first go to a domain that is blocked, then it can cause issues for some users to understand what is going on, when all they want to do is to go to the final/real link, Brave is meant to block the 3p trackers from the first link that will redirect to the real link, so blocking the document will just create a one more step and a screen for some people who might not know what it is going on. Anyway, always enable Aggressive mode, that should be done by 100% of people, unless people are just not the ones that mess with settings and want to use the browser and don't get some ads like Youtube but will not mind about 1p ones like search engine ones and such. |
I think it would be very helpful to mention this in the UI on the Create Custom Filters dialog. |
Description
No matter how I try, I can't block a website using custom filters.
Steps to reproduce
Try various syntaxes to block a site, including
Then go to facebook.com or m.facebook.com.
Actual result
The web site loads.
Expected result
It should be blocked.
Reproduces how often
Easily reproduced
Brave version
Brave 1.73.104, Chromium 131.0.6778.204
Device
Channel information
Reproducibility
Miscellaneous information
No response
The text was updated successfully, but these errors were encountered: