Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpecialArgumentsCollection has outdated argument names #120

Open
jamesemery opened this issue Dec 14, 2017 · 2 comments · May be fixed by #123
Open

SpecialArgumentsCollection has outdated argument names #120

jamesemery opened this issue Dec 14, 2017 · 2 comments · May be fixed by #123
Labels

Comments

@jamesemery
Copy link
Contributor

The arguments "showHidden" and "arguments_file" in SpecialArgumentsCollection in Barclay have the old argument style and should be changed to the new argument style.

@magicDGS
Copy link
Contributor

This is a disruptive change for downstream users not using GATK, and I would like to maintain some downstream tools based on barclay without changes in the command line (so disruptive for my users).

I suggest that, if this happen, it will be for barclay 2.0 - otherwise, I would like to make configurable the special arguments by the API user. I hope that @cmnbroad agrees on that...

@cmnbroad
Copy link
Collaborator

Yes, ideally these names would be configurable by the caller, but the parser depends on knowing what they are; making them configurable means we'd need some way to pass them in. So for now well probably just have to update them as part of 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants