-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clickhouse Support #469
Comments
Disclaimer, I've never contributed to this code base, but this enhancement would also be useful to my team and I, so I took a look at the code base. From what I can tell, each database/data sink w/ custom operators/syntax has its own set of macros, here's a macro for spark as an example. The same exists for PostgreSQL, SQLServer, BigQuery, etc. These macros are directly used/prefixes inferred (I believe) based on your profiles.yml configuration file. That's the same place you set the post-run hook. I assume adding a macro w/ clickhouse's SQL flavor in the same locations as the spark examples (full code search here) is probably sufficient. You'll also notice that there are
Lots of other instances of |
Hi @avbhandaru , You're absolutely right, and I appreciate your thorough analysis! I've actually worked on this last week and implemented the necessary changes for supporting ClickHouse. You can find my code here. I'll be opening a PR soon after completing the required tests. If you have the chance to run my code, I’d love to hear your feedback—there’s always room for improvement. Thanks again for your input—it’s always great to have collaborative feedback! |
@Y-55 Awesome! I'll give it a shot and report back (will shoot for mid next week) |
Super excited to see this work happening! |
Overview
Support Clickhouse.
What problem would this solve?
Currently when I try to run
dbt run --select dbt_artifacts
it generates errors from Clickhouse such..Would you be willing to contribute?
The text was updated successfully, but these errors were encountered: