Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract conversations logic from theme partials. #11

Open
andrewculver opened this issue May 31, 2022 · 0 comments
Open

Extract conversations logic from theme partials. #11

andrewculver opened this issue May 31, 2022 · 0 comments
Assignees

Comments

@andrewculver
Copy link
Contributor

andrewculver commented May 31, 2022

Normally I'd open this issue in the bullet_train-conversations repository, but since it's a private repository I thought it would be better if we had the conversation here. There is a metric ton of conversations business logic in the theme partial views for conversations. I'm normally not fussed about that sort of thing, but in this case I think it's actually worth doing something about. My main concern here is that the conversations logic will end up getting duplicated across a ton of themes that get produced, and it will be hard to keep them all up-to-date and working, etc. I think we need to extract as much common stuff as possible into views, view objects, or even just the models that live in bullet_train-conversations, and as much as possible isolate the views in the themes to be concerned only with styling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants