DocumentNotFoundError not bubbled up by SDK

[bwgjoseph]

From #41 (#41 (comment)), this is to track the issue separately from ottoman

[AV25242]

Thanks for tracking this separately, I have opened an issue internally with nodejs team to track

[bwgjoseph]

I have updated the test case

And also, just a note... updateMany and removeMany are not expected to throw DocumentNotFoundError since for multi-ops, it's a filter rather than providing a key/id

[AV25242]

All mutation operations are not returning back DocumentNotFoundError

[josephstgh]

findOneAndUpdate
removeById
replaceById
updateById

[AV25242]

Thanks @bwgjoseph

[bwgjoseph]

With #56, findOne is now also part of the API that has the same issue. I noticed that you have a issue created in node-ottoman repository. Do include findOne as well. Thanks

[AV25242]

fixed with beta.9

[bwgjoseph]

Can I check if the cause and context stated as undefined is intended?

test $ignoreCase function
SELECT `callsign`,`name`,`operational`,`destination`,`sche`type`,`email`,`info`,`expiresAt`,`location`,`extension`,`ouchbase airlines" AND _type="Airplane" LIMIT 1
DocumentNotFoundError: document not found
    at Z:\Development\workspace\github\bwgjoseph\mongoose-\model\create-model.ts:216:13
    at Generator.next (<anonymous>)
    at fulfilled (Z:\Development\workspace\github\bwgjosepottoman\lib\model\create-model.js:5:58) {
  cause: undefined,
  context: undefined

[bwgjoseph]

Also, another suggestion to improve the exception message.

I'm not sure if it make sense to say why the document not found? is it useful?

Something like

Given

await Airplane.findOneAndRemove({ extension: 'abc1' });

Return

document not found because the given search field (extension: 'abc1') does not match anything

Probably adjust the message format a little but I think it might provide some context when looking at the error logs so it's quite useful to have something like that