Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Completing the (legend) square #151

Open
urob opened this issue Jan 21, 2025 · 2 comments
Open

Feature request: Completing the (legend) square #151

urob opened this issue Jan 21, 2025 · 2 comments

Comments

@urob
Copy link

urob commented Jan 21, 2025

At the risk of sounding greedy, now that we have b701cef, I'd love to see the option to also add legend types for the 4 corners.

If you are fine with a quick & dirty implementation that basically mirrors b701cef, I'd be happy to make a PR. But outlining the changes, my sense was that at this point you probably would want to refactor things a bit to avoid repetition, which you would be in a much better position than me to do well.

In either case, let me know if this is something you'd be open to and whether you'd prefer a simple PR or rather first ponder about a cleaner approach.

@caksoylar
Copy link
Owner

Hey, I guess we can add those too, sure. I am having a bit of trouble with naming, I don't want to add topleft/bottomright etc. I thought maybe we have a new set of upper-case aliases T/B/L/R (and maybe C for center) and their combinations TL etc. for diagonals.

If you want to make a simple PR that might help move things along, I can refactor on top of it if I want to.

@urob
Copy link
Author

urob commented Jan 25, 2025

Sounds good. Next 1-2 weeks are busy, will cook something up after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants