You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the risk of sounding greedy, now that we have b701cef, I'd love to see the option to also add legend types for the 4 corners.
If you are fine with a quick & dirty implementation that basically mirrors b701cef, I'd be happy to make a PR. But outlining the changes, my sense was that at this point you probably would want to refactor things a bit to avoid repetition, which you would be in a much better position than me to do well.
In either case, let me know if this is something you'd be open to and whether you'd prefer a simple PR or rather first ponder about a cleaner approach.
The text was updated successfully, but these errors were encountered:
Hey, I guess we can add those too, sure. I am having a bit of trouble with naming, I don't want to add topleft/bottomright etc. I thought maybe we have a new set of upper-case aliases T/B/L/R (and maybe C for center) and their combinations TL etc. for diagonals.
If you want to make a simple PR that might help move things along, I can refactor on top of it if I want to.
At the risk of sounding greedy, now that we have b701cef, I'd love to see the option to also add legend types for the 4 corners.
If you are fine with a quick & dirty implementation that basically mirrors b701cef, I'd be happy to make a PR. But outlining the changes, my sense was that at this point you probably would want to refactor things a bit to avoid repetition, which you would be in a much better position than me to do well.
In either case, let me know if this is something you'd be open to and whether you'd prefer a simple PR or rather first ponder about a cleaner approach.
The text was updated successfully, but these errors were encountered: