Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple plug-ins to contribute lint rules and configuration #8

Open
2 tasks
nikku opened this issue Mar 4, 2020 · 2 comments
Open
2 tasks
Labels
backlog Queued in backlog enhancement New feature or request

Comments

@nikku
Copy link
Member

nikku commented Mar 4, 2020

What is the Problem

There exists certain usage scenarios where, depending on different use-cases users ship different custom linter rules (cf. camunda/camunda-modeler-custom-linter-rules-plugin#5). Right now, it is not possible to inject such.

Describe the solution you'd like

  • users may provide multiple "lint rule providing plug-ins"
  • users can configure per diagram, which lint rules are being used

Additional Context

A potential UI sketch for how linting settings could be accessed:

image

@FO-e-X
Copy link

FO-e-X commented Mar 4, 2020

Merging different rules from different plugins should be easy to realize. But you mention the case for merging with default rules, the same for merging same rules in different plugins.
The simple case, each plugin provides independent rules and overrides different default rules or override them the same way. But merging the same (default) rules with different settings for each plugins sounds a bit tricky. This case I didn't thought about... Either the last loaded plugin wins the merging or, as your idea is, the user can choose via an UI.

@DoeMoor
Copy link

DoeMoor commented May 12, 2021

"Describe the solution you'd like"
-- users can configure per diagram, which lint rules are being used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants