Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return gene context info for genomic queries #551

Open
katiestahl opened this issue Mar 27, 2024 · 10 comments
Open

return gene context info for genomic queries #551

katiestahl opened this issue Mar 27, 2024 · 10 comments
Assignees
Labels
enhancement New feature or request priority:low Low priority

Comments

@katiestahl
Copy link

katiestahl commented Mar 27, 2024

It would be helpful to have gene context info for genomic queries so that tools like VarCat can use this data and display it to users

some potential considerations:

  • return undefined/null if there is not an associated gene?
  • should we return a list of genes if there are multiple genes associated?
@katiestahl katiestahl added enhancement New feature or request priority:medium Medium priority labels Mar 27, 2024
@korikuzma
Copy link
Member

@korikuzma TODO: Look into this issue more to see if @katiestahl is able to implement or if it's better to have her as a reviewer for the PR

@korikuzma
Copy link
Member

I had forgotten that we removed returning gene context altogether when switching to draft VRS 2.0 in #512. It was not a need for downstream apps at the time, but since VarCat needs this we can add it back.

These comments are related in how we want to represent the response:
#529 (comment)
#529 (comment)
We could follow the approach in /gnomad_vcf_to_protein

It would probably be best for me to work on this since we'll probably make the scope more broad (return gene when we can regardless of molecule context). @wesleygoar when is this needed by?

@wesleygoar
Copy link

I had forgotten that we removed returning gene context altogether when switching to draft VRS 2.0 in #512. It was not a need for downstream apps at the time, but since VarCat needs this we can add it back.

These comments are related in how we want to represent the response: #529 (comment) #529 (comment) We could follow the approach in /gnomad_vcf_to_protein

It would probably be best for me to work on this since we'll probably make the scope more broad (return gene when we can regardless of molecule context). @wesleygoar when is this needed by?

Thanks @korikuzma. We definitely want this by MVP. Ideally, we could get this in by the end of the month, but I know you have a bunch of travel coming up. I will let you decide when the best time for you to tackle this issue is.

@korikuzma korikuzma self-assigned this Apr 4, 2024
@korikuzma
Copy link
Member

@katiestahl I can add you as a reviewer on this if you are interested

@korikuzma
Copy link
Member

I'm pushing this back a sprint to focus on other priorities. A solution in the meantime is just getting this info from haus, which we already pull.

@korikuzma
Copy link
Member

@wesleygoar Is it okay to do this for MANE as a first pass? See this gene-normalizer issue that I think will be needed in order to capture non-MANE genes.

@korikuzma
Copy link
Member

@wesleygoar Or would you rather just work on gene-normalizer issue (which would be a heavy lift atm and would not be able to get something out fast)

@wesleygoar
Copy link

@wesleygoar Is it okay to do this for MANE as a first pass? See this gene-normalizer issue that I think will be needed in order to capture non-MANE genes.

Yes.

Copy link

github-actions bot commented Jan 6, 2025

This issue is stale because it has been open 135 days with no activity. This issue will be closed if no further activity occurs in 14 days.

@github-actions github-actions bot added the stale label Jan 6, 2025
@korikuzma korikuzma added priority:low Low priority and removed priority:medium Medium priority stale labels Jan 6, 2025
@korikuzma
Copy link
Member

Changing priority to low since we have what we need for VarCat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:low Low priority
Projects
None yet
Development

No branches or pull requests

3 participants