From c57f3dc30e9ccb25934e39ee80c1035ef7911ec5 Mon Sep 17 00:00:00 2001 From: Colm Bhandal Date: Wed, 4 Oct 2023 17:12:46 +0100 Subject: [PATCH] Contributing docs (#140) * Contributing docs Controller and server * Update charms/argo-controller/CONTRIBUTING.md Co-authored-by: Orfeas Kourkakis * Update charms/argo-server/CONTRIBUTING.md Co-authored-by: Orfeas Kourkakis --------- Co-authored-by: Orfeas Kourkakis --- charms/argo-controller/CONTRIBUTING.md | 64 ++++++++++++++++++++++++++ charms/argo-server/CONTRIBUTING.md | 64 ++++++++++++++++++++++++++ 2 files changed, 128 insertions(+) create mode 100644 charms/argo-controller/CONTRIBUTING.md create mode 100644 charms/argo-server/CONTRIBUTING.md diff --git a/charms/argo-controller/CONTRIBUTING.md b/charms/argo-controller/CONTRIBUTING.md new file mode 100644 index 0000000..67f46f7 --- /dev/null +++ b/charms/argo-controller/CONTRIBUTING.md @@ -0,0 +1,64 @@ +# Contributing + +## Overview + +This document outlines the processes and practices recommended for contributing enhancements to `argo-controller`. + +## Talk to us First + +Before developing enhancements to this charm, you should [open an issue](/../../issues) explaining your use case. If you would like to chat with us about your use-cases or proposed implementation, you can reach us at [MLOps Mattermost public channel](https://chat.charmhub.io/charmhub/channels/mlops-documentation) or on [Discourse](https://discourse.charmhub.io/). + +## Pull Requests + +Please help us out in ensuring easy to review branches by rebasing your pull request branch onto the `main` branch. This also avoids merge commits and creates a linear Git commit history. + +All pull requests require review before being merged. Code review typically examines: + - code quality + - test coverage + - user experience for Juju administrators of this charm. + +## Recommended Knowledge + +Familiarising yourself with the [Charmed Operator Framework](https://juju.is/docs/sdk) library will help you a lot when working on new features or bug fixes. + +## Build Charm + +To build `argo-controller` run: + +```shell +charmcraft pack +``` + +## Developing + +You can use the environments created by `tox` for development. For example, to load the `unit` environment into your shell, run: + +```shell +tox --notest -e unit +source .tox/unit/bin/activate +``` + +### Testing + +Use tox for testing. For example to test the `integration` environment, run: + +```shell +tox -e integration +``` + +See `tox.ini` for all available environments. + +### Deploy + +```bash +# Create a model +juju add-model dev +# Enable DEBUG logging +juju model-config logging-config="=INFO;unit=DEBUG" +# Deploy the charm +juju deploy ./argo-controller_ubuntu-20.04-amd64.charm \ + --resource oci-image=$(yq '.resources."oci-image"."upstream-source"' metadata.yaml) + +## Canonical Contributor Agreement + +Canonical welcomes contributions to this charm. Please check out our [contributor agreement](https://ubuntu.com/legal/contributors) if you're interested in contributing. \ No newline at end of file diff --git a/charms/argo-server/CONTRIBUTING.md b/charms/argo-server/CONTRIBUTING.md new file mode 100644 index 0000000..904586e --- /dev/null +++ b/charms/argo-server/CONTRIBUTING.md @@ -0,0 +1,64 @@ +# Contributing + +## Overview + +This document outlines the processes and practices recommended for contributing enhancements to `argo-server`. + +## Talk to us First + +Before developing enhancements to this charm, you should [open an issue](/../../issues) explaining your use case. If you would like to chat with us about your use-cases or proposed implementation, you can reach us at [MLOps Mattermost public channel](https://chat.charmhub.io/charmhub/channels/mlops-documentation) or on [Discourse](https://discourse.charmhub.io/). + +## Pull Requests + +Please help us out in ensuring easy to review branches by rebasing your pull request branch onto the `main` branch. This also avoids merge commits and creates a linear Git commit history. + +All pull requests require review before being merged. Code review typically examines: + - code quality + - test coverage + - user experience for Juju administrators of this charm. + +## Recommended Knowledge + +Familiarising yourself with the [Charmed Operator Framework](https://juju.is/docs/sdk) library will help you a lot when working on new features or bug fixes. + +## Build Charm + +To build `argo-server` run: + +```shell +charmcraft pack +``` + +## Developing + +You can use the environments created by `tox` for development. For example, to load the `unit` environment into your shell, run: + +```shell +tox --notest -e unit +source .tox/unit/bin/activate +``` + +### Testing + +Use tox for testing. For example to test the `lint` environment, run: + +```shell +tox -e lint +``` + +See `tox.ini` for all available environments. + +### Deploy + +```bash +# Create a model +juju add-model dev +# Enable DEBUG logging +juju model-config logging-config="=INFO;unit=DEBUG" +# Deploy the charm +juju deploy ./argo-server_ubuntu-20.04-amd64.charm \ + --resource oci-image=$(yq '.resources."oci-image"."upstream-source"' metadata.yaml) + +## Canonical Contributor Agreement + +Canonical welcomes contributions to this charm. Please check out our [contributor agreement](https://ubuntu.com/legal/contributors) if you're interested in contributing. \ No newline at end of file