Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language server features #3169

Open
1 of 5 tasks
maan2003 opened this issue Aug 30, 2023 · 6 comments
Open
1 of 5 tasks

Language server features #3169

maan2003 opened this issue Aug 30, 2023 · 6 comments

Comments

@maan2003
Copy link
Contributor

This was started during Google Summer of Code 2023 - Editor Integration Project.

Remaining work:

  • Code Outline
  • Goto Definition
  • Goto References
  • Code aware Renaming
  • Auto Complete
Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please comment or remove the inactive label. The long term label can also be added for issues which are expected to take time.

This issue is labeled inactive because the last activity was over 90 days ago.

@github-actions github-actions bot added the inactive Issues and PRs which have been inactive for at least 90 days. label Nov 29, 2023
@github-actions github-actions bot removed the inactive Issues and PRs which have been inactive for at least 90 days. label Jul 17, 2024
Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please comment or remove the inactive label. The long term label can also be added for issues which are expected to take time.

This issue is labeled inactive because the last activity was over 90 days ago.

@github-actions github-actions bot added the inactive Issues and PRs which have been inactive for at least 90 days. label Oct 15, 2024
@ottmar-zittlau
Copy link
Contributor

Hi,

I would like to try my hand at this issue. Would that be ok?
@jonmeow I saw that you have recently cleaned up the language server.
Do you already have a plan on how to proceed with this?

Thanks and best regards
oz

@github-actions github-actions bot removed the inactive Issues and PRs which have been inactive for at least 90 days. label Jan 13, 2025
@jonmeow
Copy link
Contributor

jonmeow commented Jan 15, 2025

At present I'm planning on:

  1. Adding test infrastructure for the language server.
  2. Rewrite current handlers, particularly to do better parsed/checked document caching.
  3. Adding a few new handlers, like hover, to get a little more demonstration of functionality.

Looking at this issue, the missing items it notes (goto, renaming, auto complete) seem like they're contextual to the mentioned GSoC 2023 work; IIRC maybe more work had been planned? Where things are now, the short-term goal is just a few more features and the long-term goal is a full LSP implementation. I may end up closing this issue once the LSP implementation is a little further along, since we're not using it for tracking.

@jonmeow
Copy link
Contributor

jonmeow commented Jan 15, 2025

If you'd like to work on the language server, it may be better to wait until after the current handler rewrite is done. I think tests are really important, and I'll probably be reworking the current code to better fit caching structure. If you're inclined to pick things up, it might be helpful to check in on Discord -- #editor-integrations has been quiet, but seems a good spot to try and coordinate.

@ottmar-zittlau
Copy link
Contributor

@jonmeow Ok, that sounds good. I'll head over to discord for further discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants