Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the configuration properties to use dots instead of underscores #136

Closed
4 tasks done
carlspring opened this issue Dec 14, 2020 · 0 comments · Fixed by #139
Closed
4 tasks done

Convert the configuration properties to use dots instead of underscores #136

carlspring opened this issue Dec 14, 2020 · 0 comments · Fixed by #139
Labels
help wanted Extra attention is needed
Milestone

Comments

@carlspring
Copy link
Owner

carlspring commented Dec 14, 2020

Task Description

We should convert all the properties to use dots instead of underscores, as this is the real Java convention.

How it looks currently:

  • amazon.properties
bucket_name=/bucket
s3fs_access_key=AKIAEXAMPLEKEY
s3fs_secret_key=fadf3rafsadf3r23wafsdf9i209ifs
s3fs_region=eu-west-2
s3fs_protocol=https

How it should look:

  • amazon.properties
s3fs.bucket.name=/bucket
s3fs.access.key=AKIAEXAMPLEKEY
s3fs.secret.key=fadf3rafsadf3r23wafsdf9i209ifs
s3fs.region=eu-west-2
s3fs.protocol=https

Tasks

The following tasks will need to be carried out:

  • Convert the properties to use dots instead of underscores.
  • Make the necessary changes to the code.
  • Rename the bucket_name property to s3fs.bucket.name.
  • Update the documentation.

Task Relationships

This task:

Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant