Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to FastText v0.9.1 #4

Closed
carschno opened this issue Jul 28, 2019 · 7 comments · Fixed by #7
Closed

Update to FastText v0.9.1 #4

carschno opened this issue Jul 28, 2019 · 7 comments · Fixed by #7

Comments

@carschno
Copy link
Owner

carschno commented Jul 28, 2019

With the release of FastText v0.9.1, JFastText needs to be updated.

Based on an issue reported on original JFastText repo.

@nirzohar
Copy link

nirzohar commented Aug 7, 2019

Cannot compile 0.9.1 version. FastText using newer version of C++ which require std::sort_heap (in loss.cc line 71), so need to update the pom.xml.

@carschno
Copy link
Owner Author

carschno commented Aug 7, 2019

@nirzohar just to clarify: are you referring to compiling FastText standalone, or within JFastText? Regarding the former, I have been able to compile v0.9.1 with c++ (GCC) 8.3.1 20190223, from 2018.

Within JFastText, I'm working on updating the wrapper to handle version 0.9.1.

@carschno
Copy link
Owner Author

carschno commented Oct 25, 2019

@nirzohar The branch at https://github.com/carschno/JFastText/tree/fasttext_0.9.1 includes the latest FastText version and seems to work fine.
It depends on a fix on FastText whough which still needs to be merged (facebookresearch/fastText#936). However, the branch should already work now.

Note that this does not (yet) fix the issue that this still does not work for Windows and Mac OSX (#5).

@nirzohar
Copy link

nirzohar commented Oct 25, 2019 via email

@jingcangcang
Copy link

@carschno hi, I find the result in terminal through "./fasttext predict" have different result with java class (jft.predictProba(text)), have you verified the results of this two ways?

@nirzohar
Copy link

nirzohar commented Aug 11, 2020 via email

@carschno
Copy link
Owner Author

@carschno hi, I find the result in terminal through "./fasttext predict" have different result with java class (jft.predictProba(text)), have you verified the results of this two ways?

Hi @jingcangcang ,
Thanks for reporting this.

Could you report some more details on this in a dedicated issue. It would be important to know as many details as possible, at least:

  • What are the numbers you see in either approach?
  • How can you reproduce this?

Repository owner locked as resolved and limited conversation to collaborators Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants