Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to C++17 #96

Closed
EmperorYP7 opened this issue Apr 14, 2021 · 7 comments · Fixed by #103 or #106
Closed

Upgrade to C++17 #96

EmperorYP7 opened this issue Apr 14, 2021 · 7 comments · Fixed by #103 or #106
Assignees
Labels
enhancement New feature or request released

Comments

@EmperorYP7
Copy link
Member

The project can utilize the benefits of the modern C++17 standard. It is better, faster, and has more features than C++11. The features relevant for us include:

The above benefits would only compound with time and make this project up to date.

@hsluoyz
Copy link
Member

hsluoyz commented Apr 14, 2021

@EmperorYP7 I think we should first build the community and the ecosystem around Casbin-CPP, because I'm afraid that currently there are no people using this repo even after 1 year. If this repo doesn't make any use for a long time, we may consider putting fewer resources on it.

I'm not saying optimizing our code is not important, but I think we should first do the pinned issues:

image

@hsluoyz hsluoyz self-assigned this Apr 14, 2021
@hsluoyz hsluoyz added the enhancement New feature or request label Apr 14, 2021
@EmperorYP7
Copy link
Member Author

EmperorYP7 commented Apr 14, 2021

@hsluoyz I agree with you. But integrating with another project requires the completion of the current API to some extent, if not completely. Upgrading to C++17 can be thought of as an intermediary step towards that. I am thinking about the implementation of #79 and will soon come up with a solution.

@hsluoyz
Copy link
Member

hsluoyz commented Apr 14, 2021

Will upgrading to latest C++ standard affect the integration with other projects like mosquitto? I think if their compiler toolchain is too old, then they will not support latest C++?

@EmperorYP7
Copy link
Member Author

I don't think we would be injecting our source code directly into other projects, rather we'd be using libraries (binaries), and distribution-oriented code only. Mosquitto's codebase is mainly based on C, we'd have to create some kind of abstraction for it anyways. So I think this will not create any hindrance for integration.

@hsluoyz
Copy link
Member

hsluoyz commented Apr 14, 2021

Good!

@github-actions
Copy link

github-actions bot commented Jun 8, 2021

🎉 This issue has been resolved in version 1.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 1.20.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
2 participants