Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider refactoring build-and-run-batch-job to use GitHub webooks to push job state #13

Open
dfsnow opened this issue Dec 21, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@dfsnow
Copy link
Member

dfsnow commented Dec 21, 2023

The current Action for submitting Batch jobs to AWS checks the state of the job by periodically polling AWS using its API. This approach works well. However, GitHub Actions jobs are limited to 6 hours of run time, meaning our Batch jobs can only be polled for 6 hours (though they continue to run after the job fails).

I'm confident that a better pattern must exist to handle this than polling, given the commonness of our approach. One alternative I found via a cursory search is using the repository_dispatch trigger. Here's the discussion I found on it.

We should consider doing this in the future, though our current approach works fine for now.

@dfsnow dfsnow added the enhancement New feature or request label Dec 21, 2023
@dfsnow dfsnow changed the title Consider refactoring build-and-run-batch-job to use GitHub webooks to push job state Simplify build-and-run-batch-job design Dec 27, 2023
@dfsnow dfsnow changed the title Simplify build-and-run-batch-job design Consider refactoring build-and-run-batch-job to use GitHub webooks to push job state Dec 27, 2023
@dfsnow dfsnow added this to the GitHub Actions cleanup milestone Apr 16, 2024
@dfsnow dfsnow removed this from the GitHub Actions cleanup milestone Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants