Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't export dataset file if no datasets are provided #189

Open
gerrycampion opened this issue Jun 12, 2023 · 0 comments
Open

Don't export dataset file if no datasets are provided #189

gerrycampion opened this issue Jun 12, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@gerrycampion
Copy link
Collaborator

gerrycampion commented Jun 12, 2023

The downloading feature of the artifacts is functioning properly, and all the necessary files are accessible. However, I observed an issue when clicking the "Download Artifacts" button without any uploaded files or datasets. In this case, the system generates all the files and creates a zip file. Unfortunately, the Excel dataset file within the generated zip encounters an error when attempting to open it. Conversely, if datasets are uploaded and a dataset file is created, it opens without any issues. However, when the datasets section is left empty in the rule editor, the dataset file fails to open and produces an error. You can view the error in the attached screenshot. The json file for the dataset opens without any issues and is empty as it should be when no data is present.

60

Originally posted by @RamilCDISC in #60 (comment)

AC
If no dataset files are provided for testing, an Excel test dataset files should not be created. The other export files should be created as usual.

@gerrycampion gerrycampion added the bug Something isn't working label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant