Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There needs to be protections for published rules in editor #236

Open
SFJohnson24 opened this issue Oct 9, 2024 · 2 comments
Open

There needs to be protections for published rules in editor #236

SFJohnson24 opened this issue Oct 9, 2024 · 2 comments

Comments

@SFJohnson24
Copy link
Collaborator

In looking through editor with Gerry, the saveRule and deleteRule functions in Controls.ts, the modified and original rule are sent as payloads. We could modify to add a check for published status of the rule.
There is already a dialog for deletion, setDeleteDialog. We would need one for edits--this is also in the Controls. The old rule ID and new rule ID could be displayed. A red warning image could also be used to further draw attention to this.

@chowsanthony
Copy link

chowsanthony commented Oct 9, 2024

Can we also capture a reason when a published rule is being deleted or modified? Prompting the user to provide a reason encourages them to think twice before proceeding. This safeguard helps prevent both accidental and intentional actions. The reason, along with a timestamp and username, will be stored for recordkeeping purposes. The reason text will have a minimum length requirement to prevent junk.

@SFJohnson24
Copy link
Collaborator Author

@chowsanthony we could also do this yes. We will need to setup a new collection to store the username/rule/reason in the DB and a new endpoint to send the requests to for storage but I dont think grabbing the info and storing it should be a big lift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants