Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compression support is currently broken and should be marked as experimental #89

Open
stevefan1999-personal opened this issue Oct 12, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@stevefan1999-personal
Copy link
Contributor

It seems like clarify option names in CompilationTask and expose them in CLI · 95d675c (github.com) has broken the compression support.

Currently I forked include-flate and added a bit of a syntax to support loading files with a base directory from environmental variables, the PR is over at Allow user input environmental variables as base path by stevefan1999-personal · Pull Request #21 · SOF3/include-flate (github.com).

The syntax should looks like this

include_flate::flate!(static LEXER_AUTOMATON: [u8] from "{}" on "OUT_DIR");

Notice the new on "OUT_DIR" here. Maybe we should explicitly use this in Hime.

@stevefan1999-personal
Copy link
Contributor Author

Hmm, maybe it is really a me problem. I'm invoking Hime directly on build.rs, and obviously I would like to see the generated files at OUT_DIR, just like bindgen. Maybe we should retrofit this new syntax with a flag.

@woutersl
Copy link
Member

If it's not too much of an inconvenience, I think the best course of actions is to wait for your PR on include-flate to be merged and a version published. Then we will bump the dependency in Hime and use the new feature.

@woutersl woutersl self-assigned this Oct 16, 2023
@woutersl woutersl added the enhancement New feature or request label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants