Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download with docker - where do the files go? #126

Open
katilp opened this issue Jan 28, 2023 · 3 comments
Open

Download with docker - where do the files go? #126

katilp opened this issue Jan 28, 2023 · 3 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@katilp
Copy link
Member

katilp commented Jan 28, 2023

What happens?

Download through docker claims success but the files are not there.

How to reproduce?

$ ls
README.md
$ docker pull cernopendata/cernopendata-client
$ docker run -i -t --rm cernopendata/cernopendata-client version
0.3.0
$ docker run -i -t --rm cernopendata/cernopendata-client download-files --recid 1002 --protocol xrootd
==> Downloading file 1 of 1
  -> File: ./1002/Cert_190456-208686_8TeV_22Jan2013ReReco_Collisions12_JSON.txt
==> Success!
$ ls
README.md
$ docker run -i -t --rm cernopendata/cernopendata-client download-files --recid 1002 --protocol http
==> Downloading file 1 of 1
  -> File: ./1002/Cert_190456-208686_8TeV_22Jan2013ReReco_Collisions12_JSON.txt
  -> Progress: 35/35 KiB (100%)
==> Success!
$ ls
README.md
@katilp katilp added the bug Something isn't working label Jan 28, 2023
@katilp
Copy link
Member Author

katilp commented Jan 28, 2023

If the expected usage is the following, maybe then update the docs

$ docker run -i -t --rm  -v $PWD:/code cernopendata/cernopendata-client download-files --recid 1002
==> Downloading file 1 of 1
  -> File: ./1002/Cert_190456-208686_8TeV_22Jan2013ReReco_Collisions12_JSON.txt
  -> Progress: 35/35 KiB (100%)
==> Success!
$ ls
1002  README.md
$ ls 1002
Cert_190456-208686_8TeV_22Jan2013ReReco_Collisions12_JSON.txt

@tiborsimko
Copy link
Member

Yes, the files are downloaded into the container, so mounting a local volume inside the container is the way to go. We'll update the docs.

@tiborsimko tiborsimko added the good first issue Good for newcomers label Jan 30, 2023
@Ansh-Sarkar
Copy link

Hi @tiborsimko . Do let me know if I can work on this. Is this still something that needs to be fixed ? Trying to get started with my contributions to this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants