Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content of H5P footer does not change when container page language is changed #2805

Open
tmkarlsen opened this issue Nov 27, 2024 · 4 comments
Assignees
Labels
NDLA NDLA Edlib

Comments

@tmkarlsen
Copy link
Member

tmkarlsen commented Nov 27, 2024

Today (Edlib 2), the H5P footer language corresponds with the page's language settings, this does not seem to be the case in Edlib 3

https://staging.ndla.no/nb/r/innovasjon-og-markedsforing-sr-srl-vg2/ytre-og-indre-salgsmiljo---hva-har-du-lart/acd73b771b
https://staging.ndla.no/nb/r/tysk-1/schule-und-schulsachen/6377322737

We want the current behavior in Edlib 3 as well: Changing language on NDLA's language selector, changes the footer language of H5Ps

https://ndla.no/en/subject:1:1a05c6c7-121e-49e2-933c-580da74afe1a/topic:2:152583/topic:1:d4be2100-0b74-443f-a2b6-07c0813feaae/resource:1:152626

Screenshots (from Edlib 2)
Norsk bokmål
Image

English
Image

Norsk nynorsk
Image

@tmkarlsen tmkarlsen converted this from a draft issue Nov 27, 2024
@tmkarlsen tmkarlsen added the NDLA NDLA Edlib label Nov 27, 2024
@chrieinv chrieinv changed the title Footer: Display H5P-content in page language CA: Content of H5P footer does not change when container page language is changed Dec 16, 2024
@chrieinv chrieinv changed the title CA: Content of H5P footer does not change when container page language is changed Content of H5P footer does not change when container page language is changed Dec 16, 2024
@chrieinv
Copy link
Contributor

chrieinv commented Jan 6, 2025

So, the images are from Edlib 2?
When using Edlib 3, what language is the footer displayed in?

@tmkarlsen
Copy link
Member Author

tmkarlsen commented Jan 6, 2025

The screenshots illustrate the current and desired behavior from Edlib 2.
Using Edlib 3 only results in English for all language contexts in articles on ndla_staging.

@tmkarlsen
Copy link
Member Author

Is the language code is sent from facade, @emmachughes?

@tmkarlsen tmkarlsen moved this from 📋 Backlog to 🔖 Prioritized and ready in Edlib 3 Jan 8, 2025
@chrieinv chrieinv moved this from 🔖 Prioritized and ready to 🏗 In progress in Edlib 3 Jan 14, 2025
@chrieinv
Copy link
Contributor

In the POST to CA, /h5p/{id}, the launch_presentation_locale is set to en. This could be because the GET request to E3 Hub, /content/{id}/embed does not seem to contain any language info, making it default to English.

@chrieinv chrieinv moved this from 🏗 In progress to 🔖 Prioritized and ready in Edlib 3 Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NDLA NDLA Edlib
Projects
Status: 🔖 Prioritized and ready
Development

No branches or pull requests

2 participants