Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make async function for listen and send in ConnectionHandler #10

Open
chaeynz opened this issue Dec 25, 2023 · 1 comment
Open

Make async function for listen and send in ConnectionHandler #10

chaeynz opened this issue Dec 25, 2023 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@chaeynz
Copy link
Owner

chaeynz commented Dec 25, 2023

The goal for the listen() function is to be non-blocking.
Every message that is received should be printed straight to the command line for now.
It should also allow multiple connections at the same time, to prevent issues for this case.

The send() function should be asynchronous aswell.

The main problem is the listen() function.

@chaeynz chaeynz added the help wanted Extra attention is needed label Dec 25, 2023
@chaeynz
Copy link
Owner Author

chaeynz commented Dec 25, 2023

In 3138e94 I added a test for those functions.

The test for the sync versions of these functions pass.

I am not entirely sure if the test for the async versions is implemented correctly, but worth a try :D
This should make it easier to verify the intended behaviour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant