Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group data lookup by name doesn't respect verified field #189

Open
wlynch opened this issue Oct 7, 2024 · 0 comments
Open

Group data lookup by name doesn't respect verified field #189

wlynch opened this issue Oct 7, 2024 · 0 comments

Comments

@wlynch
Copy link
Member

wlynch commented Oct 7, 2024

Data lookups by name should only consider groups where verified = true.

Currently, we return the List request back verbatim, without checking verified - This means that we can error if multiple groups happen to have the same name, even though only one can be verified.

│ Error: more than one group found matching input
│ 
│   with data.chainguard_group.enterprise-presubmit,
│   on chainguard.tf line 5, in data "chainguard_group" "enterprise-presubmit":5: data "chainguard_group" "enterprise-presubmit" {
│ 
│ Input parameters: [id=<null>, name="enterprise-presubmit", parent_id=<null>]
│ Please provide more context to narrow query (e.g. parent_id).

We should probably default to only checking verified names, maybe with a flag to relax the constraint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant