Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Success reported when server returns 500 #4

Open
thbar opened this issue Dec 14, 2012 · 1 comment
Open

Success reported when server returns 500 #4

thbar opened this issue Dec 14, 2012 · 1 comment

Comments

@thbar
Copy link
Contributor

thbar commented Dec 14, 2012

Either on Chrome, Safari or Firefox, if the server returns an error 500, the popup tells the user that sending was successful. I'm not sure if this is related to #2 or not!

I started digging into this, it seems that __CHARM.iFrameLoaded is called while sending is true, and then calling success when it should not, probably.

@madrobby are you aware of that issue and maybe have a fix in mind, before I dive more into this?

I'm probably not JS/iFrame savvy enough to rewrite it to something more basic (using jQuery etc), so if you have an idea, let me know!
@thbar
Copy link
Contributor Author

thbar commented Dec 14, 2012

Correction: I meant I'm probably not JS/iFrame savvy enough to fix it without rewriting it etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thbar