Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async support #1

Closed
DeityLamb opened this issue Mar 16, 2024 · 6 comments · Fixed by chksum-rs/core#1, chksum-rs/reader#1, chksum-rs/writer#1 or #2
Closed

async support #1

DeityLamb opened this issue Mar 16, 2024 · 6 comments · Fixed by chksum-rs/core#1, chksum-rs/reader#1, chksum-rs/writer#1 or #2
Assignees
Labels
enhancement New feature or request

Comments

@DeityLamb
Copy link

hey! I really like your library.
Do you have any plans to support async?

@ventaquil
Copy link
Contributor

Hey! Thanks for your interest!

I tried some approach few years ago but yes, I have it in my mind to try again.

Do you have any specific requirements (like support for specific runtime)?

@ventaquil ventaquil self-assigned this Mar 16, 2024
@ventaquil ventaquil added the enhancement New feature or request label Mar 16, 2024
@DeityLamb
Copy link
Author

Not sure how specific this task is 🤔
I would be happy if there was an opportunity to asynchronously check a hash in the tokio runtime.

Thank you for the quick response 😸

@ventaquil
Copy link
Contributor

Hey @DeityLamb!

I have done some basic draft PR just to take a look at async ecosystem available nowadays.

It seems that there is no available replacement for IsTerminal::is_terminal known from the std.

I will open some issues and will see - maybe someone is going to add it. Concurrently I am planning to finish implementation and add unit tests. Keeps your fingers crossed!

@ventaquil
Copy link
Contributor

Huh, finally. Apologise @DeityLamb that it took so long time.

Should work good enough with Tokio. I have tried to implement async-std too but it didn't work very well.

Worth to notice that it may work slower than sync implementation (due to context switch and so on).

@DeityLamb
Copy link
Author

Thank you very much for your work!

@ventaquil
Copy link
Contributor

Glad to see for happy users! Come back with new suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment