Skip to content
This repository has been archived by the owner on Feb 19, 2022. It is now read-only.

Email address on http://www.serendipomatic.org/connect/ isn't a link #113

Closed
mialondon opened this issue Aug 5, 2013 · 7 comments
Closed

Comments

@mialondon
Copy link
Contributor

Would ideally also open as mailto:

@ghost ghost assigned rpalin Aug 5, 2013
@scottkleinman
Copy link
Contributor

Trying to find the lines. I will change it.

@scottkleinman
Copy link
Contributor

I see two e-mail addresses, and they both have mailto:. Am I missing something?

@rpalin
Copy link
Contributor

rpalin commented Aug 6, 2013

Originally they didn't. I made the changes this morning but thought they needed approval to go live. Still learning the GitHub thing. Sorry.

@rpalin
Copy link
Contributor

rpalin commented Aug 6, 2013

Sorry for this dumb question: I revised the email links on Connect page and, if I'm using the right vocab. "pushed" the "commit." What I don't know is how to publish. I would be glad to also do the necessary changes on About page, but could someone clarify the full push-commit-publish process (or point me to cheat sheet)? Again, sorry. I should have absorbed more of this last week.

@rlskoeser
Copy link
Contributor

@rpalin I see the change you committed in 9a311fd and the change is visible on the dev heroku site - http://dev-serendipomatic.herokuapp.com/connect/

FYI to all, if you include a github issue number in your commit message in the format #nn github will automatically link your commit and the issue together (useful if anyone needs to follow up or see what changed). You can also do the reverse - if you copy the git commit hash and add it to a comment, github will make a nice link.

We don't yet have an automated (or even very efficient) path for deploying to production (the publish part I think you're asking about). I can push the changes live at some point, but wasn't sure when I should or if things were stable (seeing lots of little changes in the commit log). Maybe someone could set up a group chat where we could confer on things like this? (thinking something more synchronous than github issue comments and more private than twitter)

@rpalin
Copy link
Contributor

rpalin commented Aug 6, 2013

Thanks, Rebecca. Your clarification helps. ... Email links were the only issue for the Connect page and the links are now set. ... I like the idea of the group chat for other issues, if necessary. ... Regarding the referenced About page revisions, which are more numerous, it looks like Brian has taken those on.

@mialondon
Copy link
Contributor Author

Ray, I love that you're diving into this. I think a wider lesson for future OWOTs is to have everyone practice working on and merging changes to the same GitHub document (perhaps when documenting ideas) so that we're all really comfortable with it during the crunch time.

I've been meaning to start a documentation to do/wishlist item and this discussion definitely points to some needed items, I'd love your contributions on #125

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants