Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Cleanup #25

Open
CWSpear opened this issue Jul 4, 2014 · 1 comment
Open

Project Cleanup #25

CWSpear opened this issue Jul 4, 2014 · 1 comment

Comments

@CWSpear
Copy link

CWSpear commented Jul 4, 2014

I won't argue that this project has fallen to the wayside a bit , but I--for one--would like to help.

I see that people are watching this repo and would care to make some improvements.

Things that I see that need some help:

  • Fixed & documented Composer integration & Redis arg fatals #21 has a few good fixes, especially when it comes to running the service (and updating the corresponding docs) in a way that makes a lot more sense as it brings it in line with php-resque and how to start that service. However, it seems as though anyone with access to this repo (Cc @chrisboulton) haven't commented or merged or anything with that aging Pull Request. This fork however, is a good place to start.
  • A major feature missing from this repo is a way to stop a scheduled before it happens. At least, it doesn't seem to be documented, and I went looking for it a bit in the code and saw no efforts to that end. We could use a token system similar to the one in php-resque and use that token to stop tasks that haven't yet started.
  • There indeed is something fishy with all the zrangebyscore stuff (f1a5596, 37ea2e2, 110e213), and we need to get to the bottom of this and fix it for good.
  • There is some confusion to the tagging system and how it relates to php-resque and this needs to be figured out.
  • Tests would help out a lot with most of these issues and protecting ourselves from reverting any issues we might have fixed once before.

I saw "we," because I am willing to help out, but without someone to merge (and there is currently no evidence that there will be), it will all be in vain. Someone can step up and create and offer to maintain a fork, but with the tight relationship that this project has with the much more popular php-resque, that may be a hard sell. But I am at least willing to volunteer to do what I can to address the list above.

Or we can move on and find a better project. Indeed, what are some good alternatives when it comes to a PHP task scheduler and queuing system?

@danhunsaker
Copy link
Contributor

Just want to point out that both projects were created by, and push access to both is still exclusively held by, the same person. So while the main project is more widely used, it isn't moving any faster while he lacks sufficient time to even review others for push access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants