Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading repo from explicit hash fails due to fix for other issues in custom nomenclature version #6

Closed
korsbakken opened this issue Oct 23, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@korsbakken
Copy link
Collaborator

Specifying git_hash parameter in iam_validation.nomenclature.defs.NomenclatureDefs.from_url fails with a git error. The reason appears to be that the loading code in the custom version of the nomenclature-iamc package currently specified in pyproject.toml tries to pull updates, but that fails if the id is an explicit hash rather than a branch name. We need to either fix the fix, or complete the PR to the nomenclature-iamc that ensures non-ASCII characters in region mappings don't cause crashes PR #406.

@korsbakken korsbakken added the bug Something isn't working label Oct 23, 2024
@korsbakken korsbakken self-assigned this Oct 23, 2024
@korsbakken
Copy link
Collaborator Author

The relevant PR in nomenclature has been merged there, and is included in release 0.20.0. Commit 43ebc3c (release v0.1.0) here therefore switches the dependency to the released nomenclature-iamc package, which closes this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant