-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strain order not updating as expected #204
Comments
Seems to be in reverse order |
I am setting up the wastewater instance as I type. Maybe that will further clarify. |
The reverse order also happens to be the ASCII order. This means the GVF sample names extracted from the header are not being matched to the key in |
I tried this same on the wastewater instance and it looks like the order was again not parsed well.
the current view of the instance is here |
It is again in ASCII order |
Seems to be working fine now. Did you clear the cache directory before rebuilding? |
It seems the strain order does not update unless you clear the cache directory AND restart the application. But we want it to change whenever the strain order file is modified. The hidden strains file is probably affected similarly. Also, this is likely not related to the docker configuration. It happens if you start the program locally too. |
I actually think we shouldn't change anything for local development, and just remember after updating the strain order/hidden strains files to 1) clear the cache directory, and 2) restart the application without generating new cache. I think that's sufficient because shouldn't expect users to muck around with the underlying asset files, which would duplicate the issue for them. For docker deployment purposes, implementing #202 should prevent the issue from happening again in the future anyways. We will not include the local cache directory when building the docker image. |
For a time-series-based production instance,
default_reference_strain_order.json
doesn't work well.I wrote a script to order the files based on the latest to earliest in terms of time. However, the order is not reflected on the instance even if the image is rebuilt and the container is restarted.
The contents of the
default_reference_strain_order.json
file for time-series data are as follows -the current view of the instance is here
The text was updated successfully, but these errors were encountered: