diff --git a/.ansible-lint b/.ansible-lint new file mode 100644 index 0000000..b55af87 --- /dev/null +++ b/.ansible-lint @@ -0,0 +1,145 @@ +--- +# .ansible-lint + +profile: production + +# Allows dumping of results in SARIF format +# sarif_file: result.sarif + +# exclude_paths included in this file are parsed relative to this file's location +# and not relative to the CWD of execution. CLI arguments passed to the --exclude +# option are parsed relative to the CWD of execution. +exclude_paths: + - playbooks/aws/results/* + - playbooks/azure/results/* +# parseable: true +# quiet: true +# strict: true +verbosity: 1 + +# # Mock modules or roles in order to pass ansible-playbook --syntax-check +mock_modules: + - cisco.catalystwan.wait_for_api_server + - azure.azcollection.azure_rm_account_info +# - zuul_return +# # note the foo.bar is invalid as being neither a module or a collection +# - fake_namespace.fake_collection.fake_module +# - fake_namespace.fake_collection.fake_module.fake_submodule +mock_roles: + - cisco.sdwan_deployment.aws_network_infrastructure + - cisco.sdwan_deployment.aws_teardown + - cisco.sdwan_deployment.aws_controllers + - cisco.sdwan_deployment.aws_edges + - cisco.sdwan_deployment.azure_network_infrastructure + - cisco.sdwan_deployment.azure_teardown + - cisco.sdwan_deployment.azure_controllers + - cisco.sdwan_deployment.azure_edges + - cisco.catalystwan.software_upgrades_remote + - cisco.catalystwan.api_ready + - cisco.catalystwan.administration_settings + - cisco.catalystwan.onboarding_controllers + - cisco.catalystwan.sync_pnp_edges + - cisco.catalystwan.activate_edges + - cisco.catalystwan.vmanage_mode + - cisco.catalystwan.health_checks + +# - mocked_role +# - author.role_name # old standalone galaxy role +# - fake_namespace.fake_collection.fake_role # role within a collection + +# Enable checking of loop variable prefixes in roles +loop_var_prefix: "^(__|{role}_)" + +# Enforce variable names to follow pattern below, in addition to Ansible own +# requirements, like avoiding python identifiers. To disable add `var-naming` +# to skip_list. +var_naming_pattern: "^[a-z_][a-z0-9_]*$" + +use_default_rules: true +# Load custom rules from this specific folder +# rulesdir: +# - ./rule/directory/ + +# Ansible-lint is able to recognize and load skip rules stored inside +# `.ansible-lint-ignore` (or `.config/ansible-lint-ignore.txt`) files. +# To skip a rule just enter filename and tag, like "playbook.yml package-latest" +# on a new line. +# Optionally you can add comments after the tag, prefixed by "#". We discourage +# the use of skip_list below because that will hide violations from the output. +# When putting ignores inside the ignore file, they are marked as ignored, but +# still visible, making it easier to address later. +skip_list: + - skip_this_tag + - name[prefix] + - var-naming[no-role-prefix] + - loop-var-prefix[wrong] + - galaxy[no-changelog] # FIXME after release + - galaxy[version-incorrect] # FIXME after release + - meta-runtime[unsupported-version] # FIXME after release + +# Ansible-lint does not automatically load rules that have the 'opt-in' tag. +# You must enable opt-in rules by listing each rule 'id' below. +enable_list: + - args + - empty-string-compare # opt-in + - no-log-password # opt-in + - no-same-owner # opt-in + - name[prefix] # opt-in + # add yaml here if you want to avoid ignoring yaml checks when yamllint + # library is missing. Normally its absence just skips using that rule. + - yaml +# Report only a subset of tags and fully ignore any others +# tags: +# - jinja[spacing] + +# Ansible-lint does not fail on warnings from the rules or tags listed below +warn_list: + - skip_this_tag + - experimental # experimental is included in the implicit list + + # - role-name + # - yaml[document-start] # you can also use sub-rule matches + +# Some rules can transform files to fix (or make it easier to fix) identified +# errors. `ansible-lint --fix` will reformat YAML files and run these transforms. +# By default it will run all transforms (effectively `write_list: ["all"]`). +# You can disable running transforms by setting `write_list: ["none"]`. +# Or only enable a subset of rule transforms by listing rules/tags here. +# write_list: +# - all + +# Offline mode disables installation of requirements.yml and schema refreshing +offline: true + +# Define required Ansible's variables to satisfy syntax check +extra_vars: + foo: bar + multiline_string_variable: | + line1 + line2 + complex_variable: ":{;\t$()" + +# Uncomment to enforce action validation with tasks, usually is not +# needed as Ansible syntax check also covers it. +# skip_action_validation: false + +# List of additional kind:pattern to be added at the top of the default +# match list, first match determines the file kind. +kinds: + # - playbook: "**/examples/*.{yml,yaml}" + # - galaxy: "**/folder/galaxy.yml" + # - tasks: "**/tasks/*.yml" + # - vars: "**/vars/*.yml" + # - meta: "**/meta/main.yml" + - yaml: "**/*.yaml-too" + +# List of additional collections to allow in only-builtins rule. +# only_builtins_allow_collections: +# - example_ns.example_collection + +# List of additions modules to allow in only-builtins rule. +# only_builtins_allow_modules: +# - example_module + +# Allow setting custom prefix for name[prefix] rule +task_name_prefix: "{stem} | " diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index f70c877..0619f25 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -8,4 +8,4 @@ - [ ] PR description is clear and comprehensive - [ ] Mentioned the issue that this PR solves (if applicable) -- [ ] Make sure you test the changes \ No newline at end of file +- [ ] Make sure you test the changes diff --git a/.github/workflows/galaxy-importer.yml b/.github/workflows/galaxy-importer.yml new file mode 100644 index 0000000..29a959c --- /dev/null +++ b/.github/workflows/galaxy-importer.yml @@ -0,0 +1,59 @@ +# Its role is to performe the same checks that would be performed when publishing to galaxy +# Running them earlier helps to detect issues locally + +name: galaxy-importer + +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + +on: + pull_request: + branches: + - main + +jobs: + galaxy-importer: + runs-on: + - ubuntu-latest + + steps: + - name: Checkout repository + uses: actions/checkout@v4 + + - name: Set up Python + uses: actions/setup-python@v5 + with: + python-version: '3.10' + + - name: Get collection namespace and name from galaxy.yml + id: collection-name + run: | + NAMESPACE=$(grep '^namespace:' galaxy.yml | awk '{print $2}' | tr -d "'\"") + NAME=$(grep '^name:' galaxy.yml | awk '{print $2}' | tr -d "'\"") + VERSION=$(grep '^version:' galaxy.yml | awk '{print $2}' | tr -d "'\"") + if [[ -z "$NAMESPACE" || -z "$NAME" || -z "$VERSION" ]]; then + echo "Error: Unable to find or parse namespace, name, or version in galaxy.yml" + exit 1 + fi + echo "Collection namespace is $NAMESPACE" + echo "Collection name is $NAME" + echo "Collection version is $VERSION" + echo "COLLECTION_NAMESPACE=$NAMESPACE" >> $GITHUB_ENV + echo "COLLECTION_NAME=$NAME" >> $GITHUB_ENV + echo "COLLECTION_VERSION=$VERSION" >> $GITHUB_ENV + + - name: Install Ansible and importer + run: | + pip install ansible==9.4.0 + pip install ansible-importer + pip install galaxy-importer + + - name: Build and install the collection + run: | + ansible-galaxy collection build $GITHUB_WORKSPACE --force + ansible-galaxy collection install $GITHUB_WORKSPACE/$COLLECTION_NAMESPACE-$COLLECTION_NAME-$COLLECTION_VERSION.tar.gz + + - name: Run ac-galaxy-importer + run: | + python -m galaxy_importer.main $GITHUB_WORKSPACE/$COLLECTION_NAMESPACE-$COLLECTION_NAME-$COLLECTION_VERSION.tar.gz diff --git a/.github/workflows/linters.yml b/.github/workflows/linters.yml new file mode 100644 index 0000000..5b2cd98 --- /dev/null +++ b/.github/workflows/linters.yml @@ -0,0 +1,43 @@ +name: Static Code Analyzer + +on: + pull_request: + + push: + branches: + - main + +jobs: + analyze-code: + runs-on: ubuntu-latest + strategy: + matrix: + python-version: ['3.10'] + defaults: + run: + shell: sh + + steps: + - name: Check out the repository + uses: actions/checkout@v4 + + - name: Set up Python + uses: actions/setup-python@v5 + with: + python-version: '3.10' + + - uses: isort/isort-action@master + with: + requirementsFiles: "requirements.txt" + + - name: Run check-yaml, end-of-file-fixer, trailing-whitespace + uses: pre-commit/action@v3.0.0 + + - name: Run ansible-lint + uses: ansible/ansible-lint@main + + - name: Install detect-secrets + run: pip install detect-secrets==1.4.0 + + - name: Run detect-secrets + run: detect-secrets scan diff --git a/.github/workflows/release-from-tag.yml b/.github/workflows/release-from-tag.yml new file mode 100644 index 0000000..65ab392 --- /dev/null +++ b/.github/workflows/release-from-tag.yml @@ -0,0 +1,70 @@ +name: Release to ansible-galaxy from tag + +on: + push: + tags: + - 'v*.*.*' + +jobs: + publish-release: + runs-on: + - ubuntu-latest + + steps: + - name: Checkout repository + uses: actions/checkout@v4 + + - name: Set up Python + uses: actions/setup-python@v5 + with: + python-version: '3.10' + + - name: Get collection version from galaxy.yml + id: collection-version + run: | + NAMESPACE=$(grep '^namespace:' galaxy.yml | awk '{print $2}' | tr -d "'\"") + NAME=$(grep '^name:' galaxy.yml | awk '{print $2}' | tr -d "'\"") + VERSION=$(grep '^version:' galaxy.yml | awk '{print $2}' | tr -d "'\"") + if [[ -z "$NAMESPACE" || -z "$NAME" || -z "$VERSION" ]]; then + echo "Error: Unable to find or parse namespace, name, or version in galaxy.yml" + exit 1 + fi + echo "Collection namespace is $NAMESPACE" + echo "Collection name is $NAME" + echo "Collection version is $VERSION" + echo "AC_NAMESPACE=$NAMESPACE" >> "$GITHUB_ENV" + echo "AC_NAME=$NAME" >> "$GITHUB_ENV" + echo "AC_VERSION=$VERSION" >> "$GITHUB_ENV" + + - name: Get Git tag + id: git-tag + run: | + TAG=${GITHUB_REF#refs/tags/} + echo "Git tag is $TAG" + echo "GIT_TAG=$TAG" >> "$GITHUB_ENV" + + - name: Compare collection version and Git tag + shell: bash + run: | + if [[ "v$AC_VERSION" == "$GIT_TAG" ]]; then + echo "The collection version matches the Git tag." + else + echo "Error: The collection version ($AC_VERSION) does not match the Git tag ($GIT_TAG)." + exit 1 + fi + + - name: Install Ansible + run: | + pip install ansible==9.4.0 + + - name: Build collection + run: | + ansible-galaxy collection build $GITHUB_WORKSPACE --force + + - name: Check collection install locally to verify tar.gz correctness + run: | + ansible-galaxy collection install $GITHUB_WORKSPACE/$AC_NAMESPACE-$AC_NAME-$AC_VERSION.tar.gz + + - name: Publish Collection to Ansible-Galaxy + run: | + ansible-galaxy collection publish $GITHUB_WORKSPACE/$AC_NAMESPACE-$AC_NAME-$AC_VERSION.tar.gz --api-key "${{ secrets.ANSIBLE_GALAXY_API_KEY }}" diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml new file mode 100644 index 0000000..26c5838 --- /dev/null +++ b/.pre-commit-config.yaml @@ -0,0 +1,18 @@ +repos: + - repo: https://github.com/pre-commit/pre-commit-hooks + rev: v4.4.0 + hooks: + - id: check-yaml + - id: end-of-file-fixer + - id: trailing-whitespace + + - repo: https://github.com/ansible-community/ansible-lint.git + rev: v24.2.1 # latest release tag from https://github.com/ansible-community/ansible-lint/releases/ + hooks: + - id: ansible-lint + files: \.(yaml|yml)$ + + - repo: https://github.com/Yelp/detect-secrets + rev: v1.4.0 + hooks: + - id: detect-secrets diff --git a/README.md b/README.md index 71fd1d8..4476d8d 100644 --- a/README.md +++ b/README.md @@ -1,17 +1,17 @@ # Cisco SDWAN aaC ```text - - ┌───────────────────────────────┐ - │ cisco.sdwan │ - └───────▲───────────────▲───────┘ - │ │ - ┌──────┘ └──────┐ - │ │ - ┌───────────┴──────────────┐ ┌─────────┴──────────┐ - │ cisco.sdwan_deployment │ │ cisco.catalystwan │ - └──────────────────────────┘ └────────────────────┘ - + + ┌───────────────────────────────┐ + │ cisco.sdwan │ + └───────▲───────────────▲───────┘ + │ │ + ┌──────┘ └──────┐ + │ │ + ┌───────────┴──────────────┐ ┌─────────┴──────────┐ + │ cisco.sdwan_deployment │ │ cisco.catalystwan │ + └──────────────────────────┘ └────────────────────┘ + ``` [ansible-collection-sdwan](https://github.com/cisco-open/ansible-collection-sdwan) combine [SDWAN Deployment](https://github.com/cisco-open/ansible-collection-sdwan-deployment) and @@ -22,14 +22,16 @@ Let users to fully deploy, onboard and upgrade their SD-WAN topology. ## Table of Contents - [Overview](#overview) -- [Prerequisites](#prerequisites) -- [Installation](#installation) -- [Usage](#usage) +- [Requirements](#requirements) +- [Installing this collection](#installing-this-collection) +- [Using this collection](#using-this-collection) - [Troubleshooting](#troubleshooting) - [Containerized variant WIP](#containerized-variant-wip) +- [Contributing](#contributing) - [Useful links and Getting Started](#useful-links-and-getting-started) - [License](#license) -- [Contributing](#contributing) +- [Code of Conduct](#code-of-conduct) +- [Releasing, Versioning and Depracation](#releasing-versioning-and-deprecation) --- @@ -44,7 +46,7 @@ By leveraging these Ansible resources, [ansible-collection-sdwan](https://github [ansible-collection-sdwan](https://github.com/cisco-open/ansible-collection-sdwan) illustrates the power of Ansible's modularity and the significant benefits of using roles, custom modules, and collections for automating network operations. It stands as an indispensable resource for organizations looking to implement Infrastructure as Code (IaC) within their network infrastructure and embrace a more agile and DevOps-oriented approach to network management. -## Prerequisites +## Requirements This project utilizes a tech stack that includes Python, Ansible (and Ansible Galaxy), AWS cloud (Boto/Boto3, authentication with AWS CLI) Azure cloud (ansible azure collection) and finally Cisco SD-WAN. @@ -90,23 +92,58 @@ Current version of the full workflow for bringup SD-WAN assumes that users are f --- -## Installation +## Installing this collection + +### Install by cloning this repostiory - recommended way + +You can install collection by first cloning this repository: + +```bash +git clone git@github.com:cisco-open/ansible-collection-sdwan.git +``` -With supported version of Python (>=3.10) installed, you can first set up your environment with: +Then setting your python environment. +Recommended way: use supported version of Python (>=3.10) and set up your environment with: ```bash python3 -m venv source /bin/activate +pip install -r requirements.txt --no-deps ``` -And then install python and ansible requirements: +And then install ansible requirements: ```bash -pip install -r requirements.txt --no-deps ansible-galaxy install -r requirements.yml ``` -Note: For python packages installation troubleshooting see [python-packages-installation](#5-python-packages-installation) +### Install with Ansible Galaxy + +***Note*** that when installing this collection with `ansible-galaxy` command, it will be placed inside your system collections path. That migth introduce additional complexity for using configuration files etc. + +You can install this collection with the Ansible Galaxy CLI (requires `ansible` package installed) + +```bash +ansible-galaxy collection install cisco.sdwan +``` + +The python module dependencies are not installed by ansible-galaxy. They can be manually installed using pip. +Recommended way: use supported version of Python (>=3.10) and set up your environment with: + +```bash +python3 -m venv +source /bin/activate +``` + +And then install python requirements: + +```bash +pip install -r requirements.txt --no-deps +``` + +

+ +***Note***: For python packages installation troubleshooting see [python-packages-installation](#5-python-packages-installation) Verify that your ansible version is using python modules from vevn by using test playbook: @@ -126,7 +163,7 @@ If playbook finished without any failed tasks, environment is ready for next tas If requirements have been installed and tasks returned information about missing packages, please see [Troubleshooting](#troubleshooting) -## Usage +## Using this collection ### Ansible Vault prerequisite @@ -151,7 +188,7 @@ and for aws `playbooks/aws/pnp_credentials.yml`. Encrypt the pnp credentials file with your valut password by running: ```bash -ansible-vault encrypt --vault-password-file=vault-password.txt playbooks/azure/pnp_credentials.yml +ansible-vault encrypt --vault-password-file=vault-password.txt playbooks/azure/pnp_credentials.yml ``` From now, `playbooks/azure/pnp_credentials.yml` or `playbooks/aws/pnp_credentials.yml` file will be encrypted. @@ -160,7 +197,7 @@ In order to run playbook that requires pnp_credentials, users have to specify pa Example: ```bash -ansible-playbook playbooks/azure/test_vault_usage.yml --vault-password-file=vault-password.txt +ansible-playbook playbooks/azure/non-existing-exmple.yml --vault-password-file=vault-password.txt ``` ### Configuration file @@ -320,3 +357,13 @@ See [LICENSE](./LICENSE) file. ## Contributing See [Contributing](./docs/CONTRIBUTING.md) file. + +## Code of Conduct + +See [Code of Conduct](./docs/CODE_OF_CONDUCT.md) file. + +## Releasing, Versioning and Deprecation + +This collection follows Semantic Versioning. More details on versioning can be found in [Understanding collection versioning](https://docs.ansible.com/ansible/latest/dev_guide/developing_collections_distributing.html#understanding-collection-versioning). + +New minor and major releases as well as deprecations will follow new releases and deprecations of the Cisco Catalystwan SDK, a Python SDK, which this project relies on. diff --git a/galaxy.yml b/galaxy.yml new file mode 100644 index 0000000..27ccdb8 --- /dev/null +++ b/galaxy.yml @@ -0,0 +1,29 @@ +namespace: cisco +name: sdwan +version: 0.1.0 +readme: README.md +authors: + - Arkadiusz Cichon +description: Ansible collection to provide full workflows for deployment, upgrades and configuration + +repository: https://github.com/cisco-open/ansible-collection-sdwan +documentation: https://github.com/cisco-open/ansible-collection-sdwan/blob/main/README.md +homepage: https://github.com/cisco-open/ansible-collection-sdwan +issues: https://github.com/cisco-open/ansible-collection-sdwan/issues + +license: + - "GPL-3.0-only" + +tags: + - cisco + - sdwan + - catalystwan + - networking + +dependencies: + "cisco.sdwan_deployment": ">=0.1.1" + "cisco.catalystwan": ">=0.1.1" + "amazon.aws": ">=6.5.0" + "azure.azcollection": ">=1.19.0" + +build_ignore: [] diff --git a/meta/requirements.yml b/meta/requirements.yml new file mode 100644 index 0000000..f62e2b1 --- /dev/null +++ b/meta/requirements.yml @@ -0,0 +1,13 @@ +--- + +collections: + - name: amazon.aws + version: 6.5.0 + - name: azure.azcollection + version: 1.19.0 + - name: git@github.com:cisco-open/ansible-collection-catalystwan.git + type: git + version: main + - name: git@github.com:cisco-open/ansible-collection-sdwan-deployment.git + type: git + version: main diff --git a/meta/runtime.yml b/meta/runtime.yml new file mode 100644 index 0000000..0a00844 --- /dev/null +++ b/meta/runtime.yml @@ -0,0 +1,3 @@ +# meta/runtime.yml +--- +requires_ansible: '>=2.16.6' diff --git a/playbooks/aws/aws_sdwan_config.yml b/playbooks/aws/aws_sdwan_config.yml index 9f708a1..d273ded 100644 --- a/playbooks/aws/aws_sdwan_config.yml +++ b/playbooks/aws/aws_sdwan_config.yml @@ -33,6 +33,8 @@ aws_allowed_subnets: null # Controllers # ############################### +admin_password: null + # vManage aws_vmanage_ami_id: null aws_vmanage_instance_type: "c5.9xlarge" @@ -63,8 +65,6 @@ vsmart_instances: site_id: 333 - - ################################ # Edge devices # ################################ diff --git a/playbooks/aws/pnp_credentials.yml b/playbooks/aws/pnp_credentials.yml index 914586d..aa13287 100644 --- a/playbooks/aws/pnp_credentials.yml +++ b/playbooks/aws/pnp_credentials.yml @@ -1,4 +1,4 @@ --- pnp_username: null -pnp_password: null +pnp_password: null # pragma: allowlist secret diff --git a/playbooks/aws/test_env.yml b/playbooks/aws/test_env.yml index 5b8a68e..3419024 100644 --- a/playbooks/aws/test_env.yml +++ b/playbooks/aws/test_env.yml @@ -17,5 +17,5 @@ manager_authentication: url: "dummy" username: "dummy" - password: "dummy" + password: "dummy" # pragma: allowlist secret check_mode: true diff --git a/playbooks/aws/test_variables.yml b/playbooks/aws/test_variables.yml index 049af53..27df34f 100644 --- a/playbooks/aws/test_variables.yml +++ b/playbooks/aws/test_variables.yml @@ -20,6 +20,7 @@ aws_vbond_ami_id: "{{ aws_vbond_ami_id | default() }}" aws_vsmart_ami_id: "{{ aws_vsmart_ami_id | default() }}" aws_cedge_ami_id: "{{ aws_cedge_ami_id | default() }}" + admin_password: "{{ admin_password | default() }}" tasks: - name: Assert that required variables are provided ansible.builtin.assert: @@ -63,4 +64,4 @@ - name: Assert that required `pnp_username` and `pnp_password` variables are provided ansible.builtin.fail: msg: "Required variables: `pnp_username` and `pnp_password` variables are missing" - when: pnp_vars is defined and (pnp_vars.failed|default(False)) + when: pnp_vars is defined and (pnp_vars.failed | default(False)) diff --git a/playbooks/azure/azure_sdwan_config.yml b/playbooks/azure/azure_sdwan_config.yml index 00faee3..0fd1953 100644 --- a/playbooks/azure/azure_sdwan_config.yml +++ b/playbooks/azure/azure_sdwan_config.yml @@ -22,14 +22,15 @@ az_resources_prefix: "{{ organization_name }}" # az_allowed_subnets: is list of subnets, that are allowed to access your instances # # example configuration is: -# az_allowed_subnets: -# - 15.15.0.0/16 -# - 10.10.0.0/16 +az_allowed_subnets: null + ############################### # Controllers # ############################### +admin_password: null + # vManage az_vmanage_image_vhd_source: null az_vmanage_vm_size: "Standard_F16s_v2" diff --git a/playbooks/azure/full_deploy_and_configure.yml b/playbooks/azure/full_deploy_and_configure.yml index ee157bd..23dcda1 100644 --- a/playbooks/azure/full_deploy_and_configure.yml +++ b/playbooks/azure/full_deploy_and_configure.yml @@ -50,7 +50,6 @@ - cisco.sdwan_deployment.azure_edges - # Onboard edge devices and wait for their reachability - name: Activate and validate edge devices hosts: localhost diff --git a/playbooks/azure/pnp_credentials.yml b/playbooks/azure/pnp_credentials.yml index 914586d..aa13287 100644 --- a/playbooks/azure/pnp_credentials.yml +++ b/playbooks/azure/pnp_credentials.yml @@ -1,4 +1,4 @@ --- pnp_username: null -pnp_password: null +pnp_password: null # pragma: allowlist secret diff --git a/playbooks/azure/test_env.yml b/playbooks/azure/test_env.yml index 9342b50..655486e 100644 --- a/playbooks/azure/test_env.yml +++ b/playbooks/azure/test_env.yml @@ -27,5 +27,5 @@ manager_authentication: url: "dummy" username: "dummy" - password: "dummy" + password: "dummy" # pragma: allowlist secret check_mode: true diff --git a/playbooks/azure/test_variables.yml b/playbooks/azure/test_variables.yml index b8183c3..457c594 100644 --- a/playbooks/azure/test_variables.yml +++ b/playbooks/azure/test_variables.yml @@ -22,6 +22,7 @@ az_cedge_image_publisher: "{{ az_cedge_image_publisher | default() }}" az_cedge_image_sku: "{{ az_cedge_image_sku | default() }}" az_cedge_image_version: "{{ az_cedge_image_version | default() }}" + admin_password: "{{ admin_password | default() }}" tasks: - name: Assert that required variables are provided ansible.builtin.assert: @@ -65,4 +66,4 @@ - name: Assert that required `pnp_username` and `pnp_password` variables are provided ansible.builtin.fail: msg: "Required variables: `pnp_username` and `pnp_password` variables are missing" - when: pnp_vars is defined and (pnp_vars.failed|default(False)) \ No newline at end of file + when: pnp_vars is defined and (pnp_vars.failed | default(False)) diff --git a/playbooks/software_upgrades_with_remote_server.yml b/playbooks/software_upgrades_with_remote_server.yml index f9ef542..994c21c 100644 --- a/playbooks/software_upgrades_with_remote_server.yml +++ b/playbooks/software_upgrades_with_remote_server.yml @@ -15,7 +15,7 @@ remote_server_password: null remote_server_image_location_prefix: null vmanage_remote_software_filename: null - viptela_remote_software_filename: null + viptela_remote_software_filename: null cedge_remote_software_filename: null controller_software_version_to_activate: null # For Remote Images that don't report its version in repository, we have to provide that value directly edge_software_version_to_activate: null # For Remote Images that don't report its version in repository, we have to provide that value directly