Skip to content
This repository has been archived by the owner on Oct 1, 2021. It is now read-only.

In image.py, SECTION_CHAR should be better defined #5

Open
cj-wong opened this issue Feb 3, 2021 · 0 comments
Open

In image.py, SECTION_CHAR should be better defined #5

cj-wong opened this issue Feb 3, 2021 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@cj-wong
Copy link
Owner

cj-wong commented Feb 3, 2021

photo-dash/photo_dash/image.py

Line 36 in 89bc82f

SECTION_CHAR = int(16 * 10 / 16)

Right now, the value uses hard-coded numbers to determine the pixel width of one monospace character, given a font and size.

Plus, the 16 * 10 / 16 looks very tacky...
@cj-wong cj-wong added the documentation Improvements or additions to documentation label Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cj-wong