Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Enhance result string for merge #312

Closed
danghai opened this issue Aug 4, 2018 · 1 comment
Closed

Enhance result string for merge #312

danghai opened this issue Aug 4, 2018 · 1 comment
Labels
invalid This doesn't seem right

Comments

@danghai
Copy link
Contributor

danghai commented Aug 4, 2018

Because we are going to implement the ordered mixture of merge arguments following multiple patch, the result string only stores True/False. In my opinion, result string should be enhanced by providing more detail information. Ex:

<Name of Patch1> : True
<Name of Patch2> : True
<Name of Patch3> : False

What do you think?

@veruu veruu added the invalid This doesn't seem right label Aug 6, 2018
@veruu
Copy link
Contributor

veruu commented Aug 6, 2018

The result_string is meant to be an indicator of the command result - something like permanent storage of return code. There is a huge discussion in meta/6 if you want to follow the reasoning, but the short version is

  • if the command didn't complete (eg. got an unexpected exception), there is no file with the result
  • if the command completed unsuccessfully, there is a result file with false string
  • if the command completed successfully, there is a result file with true string

The strings are shell commands at the same time, so the files are easy to process by machine. What patches were applied should be present in the report itself (report_string and file that's created if the command completes).

@veruu veruu closed this as completed Aug 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants