From 8ed5c87359326453784e50a93e2a6ebce6f70e56 Mon Sep 17 00:00:00 2001
From: Florent DELAHAYE <florent.delahaye@fr.clara.net>
Date: Fri, 10 Jan 2025 17:55:05 +0100
Subject: [PATCH] fix: integration_aws-alb: enable all alarms by default

---
 modules/integration_aws-alb/conf/03-lb-4xx.yaml     | 1 -
 modules/integration_aws-alb/conf/05-target-4xx.yaml | 1 -
 modules/integration_aws-alb/variables-gen.tf        | 4 ++--
 3 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/modules/integration_aws-alb/conf/03-lb-4xx.yaml b/modules/integration_aws-alb/conf/03-lb-4xx.yaml
index b225ed13d..ddcbeab2b 100644
--- a/modules/integration_aws-alb/conf/03-lb-4xx.yaml
+++ b/modules/integration_aws-alb/conf/03-lb-4xx.yaml
@@ -26,7 +26,6 @@ rules:
     lasting_duration: 15m
     lasting_at_least: 0.9
     append_condition: and when(requests > ${var.minimum_traffic})
-    disabled: true
   major:
     threshold: 95
     comparator: ">"
diff --git a/modules/integration_aws-alb/conf/05-target-4xx.yaml b/modules/integration_aws-alb/conf/05-target-4xx.yaml
index 5d3888dff..1e6fff490 100644
--- a/modules/integration_aws-alb/conf/05-target-4xx.yaml
+++ b/modules/integration_aws-alb/conf/05-target-4xx.yaml
@@ -26,7 +26,6 @@ rules:
     lasting_duration: 15m
     lasting_at_least: 0.9
     append_condition: and when(requests > ${var.minimum_traffic})
-    disabled: true
   major:
     threshold: 95
     comparator: ">"
diff --git a/modules/integration_aws-alb/variables-gen.tf b/modules/integration_aws-alb/variables-gen.tf
index 83af98b31..cf7730c4b 100644
--- a/modules/integration_aws-alb/variables-gen.tf
+++ b/modules/integration_aws-alb/variables-gen.tf
@@ -269,7 +269,7 @@ variable "alb_4xx_disabled" {
 variable "alb_4xx_disabled_critical" {
   description = "Disable critical alerting rule for alb_4xx detector"
   type        = bool
-  default     = true
+  default     = null
 }
 
 variable "alb_4xx_disabled_major" {
@@ -472,7 +472,7 @@ variable "target_4xx_disabled" {
 variable "target_4xx_disabled_critical" {
   description = "Disable critical alerting rule for target_4xx detector"
   type        = bool
-  default     = true
+  default     = null
 }
 
 variable "target_4xx_disabled_major" {