From 2e025aeccddd2684c1152935498be8e3c3050e2b Mon Sep 17 00:00:00 2001 From: Harshg999 Date: Mon, 6 Nov 2023 15:28:43 +0530 Subject: [PATCH] [raz] Some review improvements --- desktop/core/src/desktop/lib/fs/gc/gsconnection.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/desktop/core/src/desktop/lib/fs/gc/gsconnection.py b/desktop/core/src/desktop/lib/fs/gc/gsconnection.py index 8a34b233cd5..13b1874b187 100644 --- a/desktop/core/src/desktop/lib/fs/gc/gsconnection.py +++ b/desktop/core/src/desktop/lib/fs/gc/gsconnection.py @@ -41,8 +41,8 @@ class SignedUrlGSConnection(GSConnection): https://github.com/boto/boto/blob/develop/boto/s3/connection.py https://github.com/boto/boto/blob/develop/boto/connection.py - Example of a presigned GS Url declaring a `list all buckets` call: - https://s3-us-west-1.amazonaws.com/?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIA23E77ZX2HVY76YGL%2F20210505%2Fus-west-1%2Fs3%2Faws4_request&X-Amz-Date=20210505T171457Z&X-Amz-Expires=3600&X-Amz-SignedHeaders=host&X-Amz-Signature=994d0ec2ca19a00aa2925fe62cab0e727591b1951a8a47504b2b9124facbd6cf + Example of a presigned GS Url declaring a `list bucket` call: + https://hue-gs-bucket.storage.googleapis.com/?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIA23E77ZX2HVY76YGL%2F20210505%2Fus-west-1%2Fs3%2Faws4_request&X-Amz-Date=20210505T171457Z&X-Amz-Expires=3600&X-Amz-SignedHeaders=host&X-Amz-Signature=994d0ec2ca19a00aa2925fe62cab0e727591b1951a8a47504b2b9124facbd6cf """ def __init__(self, username, gs_access_key_id=None, gs_secret_access_key=None, is_secure=True, port=None, proxy=None, proxy_port=None, @@ -138,7 +138,7 @@ def make_request(self, method, bucket='', key='', headers=None, data='', if raz_headers is not None: http_request.headers.update(raz_headers) else: - LOG.error('We got back empty header from Raz for the request %s' % http_request) + raise Exception('Aborting operation: We got back empty header from Raz for the request %s' % http_request) LOG.debug('Overriden: %s' % http_request)