Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imminent v2 api death and impact on client intialization #220

Closed
thelangley opened this issue Dec 16, 2024 · 5 comments · Fixed by #221
Closed

Imminent v2 api death and impact on client intialization #220

thelangley opened this issue Dec 16, 2024 · 5 comments · Fixed by #221

Comments

@thelangley
Copy link

CF API V2 is about to be retired. I think the first cut of cf-deployment from January 2025 onwards will no longer have v2 enabled by default

https://lists.cloudfoundry.org/g/cf-dev/message/9487

We've disabled it in our deployment ahead of time to test and although the majority of the V3 API calls in this library are supported, the init of the client requires V2 API so it no can no longer initialize.

We also get errors like below, because the V2 API no longer responds

 File "/usr/local/lib/python3.10/site-packages/cloudfoundry_client/client.py", line 210, in _get_info
    root_links["cloud_controller_v2"]["meta"]["version"],
KeyError: 'cloud_controller_v2'
@pburkholder
Copy link

@thelangley Do you have a list of all the things that are prone to break with the death of V2?

antechrestos added a commit that referenced this issue Jan 3, 2025
Allow client without no V2 api

Closes #220
antechrestos added a commit that referenced this issue Jan 3, 2025
Allow client without no V2 api

Closes #220
antechrestos added a commit that referenced this issue Jan 3, 2025
Allow client without no V2 api

Closes #220
antechrestos added a commit that referenced this issue Jan 3, 2025
Allow client without no V2 api

Closes #220
@antechrestos
Copy link
Member

antechrestos commented Jan 3, 2025

@thelangley @pburkholder I've just made a PR #221 that allows starting a client without V2 endpoint.

The only thing that won't work will be

  • push operation yet it was experimental
  • log streaming might not wor (there is a /v2/read in log streaming urk yet base url of stream log exposed on root api is another endpoint so I think they are not linked )
  • direct access without v2 such as client.organizations as requested in Default existing entity attributes to v2 #43 ; I think this should be removed but kept it for now

What do you think of the evolution?

If you're ok I will merge it and make a release

antechrestos added a commit that referenced this issue Jan 4, 2025
Allow client without no V2 api

Closes #220
@thelangley
Copy link
Author

Thank you so much. This looks ace, could a release please be made and we'll test it out for you?

@antechrestos
Copy link
Member

@thelangley I've just released the 1.38.0

@thelangley
Copy link
Author

Tested this out in our use case and it's working nicely.

Thank you @antechrestos, appreciate your hard work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants