Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sasl not working #61

Open
kohlrak opened this issue Apr 19, 2024 · 17 comments
Open

sasl not working #61

kohlrak opened this issue Apr 19, 2024 · 17 comments

Comments

@kohlrak
Copy link

kohlrak commented Apr 19, 2024

I use TCP dump and tried to find exactly why I kept not logging me in and it turns out that sasl is not sending The exact information being put in. Copying and pasting the password to ident password and it works. My server correctly forwards it for other irc clients.my suspicion is that one of the characters holds significance in yml, seeing as it refuses to keep the single quotes around it was the result of a keyboard smash.

@cnaude
Copy link
Owner

cnaude commented Apr 19, 2024

Yaml can be a little tricky with string formatting. I would recommend putting single quotes around the password in the yml file. This should be able to handle most use cases. If your password has a single quote in it then you can use double quotes around the password instead.

ident-password: 'password'

@kohlrak
Copy link
Author

kohlrak commented Apr 20, 2024

Yaml can be a little tricky with string formatting. I would recommend putting single quotes around the password in the yml file. This should be able to handle most use cases. If your password has a single quote in it then you can use double quotes around the password instead.

ident-password: 'password'

I tried doing that. I noticed that every time I tried modifying it and reloading within Minecraft it would erase the quotes. Or is it one of those we can't modify and reload when running?

@kohlrak kohlrak closed this as completed Apr 20, 2024
@kohlrak kohlrak reopened this Apr 20, 2024
@cnaude
Copy link
Owner

cnaude commented May 6, 2024

I was thinking about how to resolve this issue and I wonder if using a file reference to a password file would help. The way that the yaml library updates the yaml file can sometimes cause issues like this, especially when there are a bunch of special characters that need to be escaped.

@kohlrak
Copy link
Author

kohlrak commented May 7, 2024 via email

@cnaude
Copy link
Owner

cnaude commented May 7, 2024

I don't currently use sasl. The yaml library is likely just not handling one of the special characters properly. I can create a version of the plugin it's able to load the sasl password from another file instead of from the yaml. Would you be willing to test that if I create it?

@kohlrak
Copy link
Author

kohlrak commented May 9, 2024 via email

@cnaude
Copy link
Owner

cnaude commented May 12, 2024

https://jenkins.chrisnaude.com/jenkins/job/PurpleIRC-spigot/379/

This new version has a new option in the bot yaml:

sasl-password-file: password.txt

@kohlrak
Copy link
Author

kohlrak commented May 13, 2024 via email

@kohlrak
Copy link
Author

kohlrak commented May 13, 2024 via email

@cnaude
Copy link
Owner

cnaude commented May 13, 2024 via email

@kohlrak
Copy link
Author

kohlrak commented May 13, 2024 via email

@kohlrak
Copy link
Author

kohlrak commented May 13, 2024 via email

@cnaude
Copy link
Owner

cnaude commented May 13, 2024 via email

@kohlrak
Copy link
Author

kohlrak commented May 14, 2024 via email

@cnaude
Copy link
Owner

cnaude commented May 15, 2024

@kohlrak
Copy link
Author

kohlrak commented May 16, 2024 via email

cnaude added a commit that referenced this issue May 18, 2024
cnaude added a commit that referenced this issue May 18, 2024
#61 fix edge case with sasl protocol
@cnaude
Copy link
Owner

cnaude commented May 18, 2024

Well PircBotX now compiles on JDK21. :D
PurpleIRC-1.0-381 has been uploaded and contains the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants