Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling inactive mission doesnt trigger onOrderProcessed again #33

Open
cmraaron opened this issue Aug 25, 2023 · 0 comments
Open

Cancelling inactive mission doesnt trigger onOrderProcessed again #33

cmraaron opened this issue Aug 25, 2023 · 0 comments

Comments

@cmraaron
Copy link

Given an active but processed order, onOrderProcessed handler is called and isOrderProcessedHandlerInvoked is assigned true
But later the order may transition isActive from false to true, eg, by way of a cancel instant action

onOrderProcessed is not called again with the updated isActive state, but I'd expect it to be.
calling onOrderProcessed is prevented by checking isOrderProcessedHandlerInvoked here

if (result !== false && !cache.isOrderProcessedHandlerInvoked) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant