Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/catalog/externalcatalog: TestExtractIngestExternalCatalog failed #138639

Closed
cockroach-teamcity opened this issue Jan 8, 2025 · 2 comments · Fixed by #138928 or mohini-crl/cockroach#208
Closed

sql/catalog/externalcatalog: TestExtractIngestExternalCatalog failed #138639

cockroach-teamcity opened this issue Jan 8, 2025 · 2 comments · Fixed by #138928 or mohini-crl/cockroach#208
Assignees
@msbutler
Labels
A-disaster-recovery branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-2 Issues/test failures with a fix SLA of 3 months T-disaster-recovery

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jan 8, 2025 •
edited by cockroach-jira-scripts
Loading

sql/catalog/externalcatalog.TestExtractIngestExternalCatalog failed on master @ 1aba4038242990fdb37a5317512fc5e82d6334fe:

=== RUN   TestExtractIngestExternalCatalog
    test_log_scope.go:165: test logs captured to: outputs.zip/logTestExtractIngestExternalCatalog3943006934
    test_log_scope.go:76: use -show-logs to present logs inline
    external_catalog_test.go:140: -- test log scope end --
test logs left over in: outputs.zip/logTestExtractIngestExternalCatalog3943006934
--- FAIL: TestExtractIngestExternalCatalog (17.65s)
=== RUN   TestExtractIngestExternalCatalog/basic
    sql_runner.go:298: error executing 'SELECT name FROM crdb_internal.tables WHERE state = 'DROP'': pq: referenced descriptor ID 109: looking up ID 109: descriptor not found
    --- FAIL: TestExtractIngestExternalCatalog/basic (3.06s)

Parameters:

  • attempt=1
  • race=true
  • run=2
  • shard=1
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/disaster-recovery

This test on roachdash | Improve this report!

Jira issue: CRDB-46176
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-disaster-recovery labels Jan 8, 2025
@msbutler msbutler self-assigned this Jan 8, 2025
@msbutler msbutler removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Jan 9, 2025
@cockroach-teamcity
Copy link
Member Author

sql/catalog/externalcatalog.TestExtractIngestExternalCatalog failed on master @ dc789b58edb67ae00f16117e2daee179fedc4a19:

=== RUN   TestExtractIngestExternalCatalog
    test_log_scope.go:165: test logs captured to: outputs.zip/logTestExtractIngestExternalCatalog747474018
    test_log_scope.go:76: use -show-logs to present logs inline
    external_catalog_test.go:140: -- test log scope end --
test logs left over in: outputs.zip/logTestExtractIngestExternalCatalog747474018
--- FAIL: TestExtractIngestExternalCatalog (17.06s)
=== RUN   TestExtractIngestExternalCatalog/basic
    sql_runner.go:298: error executing 'SELECT name FROM crdb_internal.tables WHERE state = 'DROP'': pq: referenced descriptor ID 109: looking up ID 109: descriptor not found
    --- FAIL: TestExtractIngestExternalCatalog/basic (2.74s)

Parameters:

  • attempt=1
  • race=true
  • run=1
  • shard=1
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/catalog/externalcatalog.TestExtractIngestExternalCatalog failed on master @ bffe1f175054fe4e8f01a037bfdca0efe2f9ba14:

=== RUN   TestExtractIngestExternalCatalog
    test_log_scope.go:165: test logs captured to: outputs.zip/logTestExtractIngestExternalCatalog1351655853
    test_log_scope.go:76: use -show-logs to present logs inline
I250113 11:34:23.724496 1 (gostd) rand.go:246  [-] 1  random seed: -64206572984996385
    external_catalog_test.go:140: -- test log scope end --
--- FAIL: TestExtractIngestExternalCatalog (17.25s)
=== RUN   TestExtractIngestExternalCatalog/basic
    sql_runner.go:298: error executing 'SELECT name FROM crdb_internal.tables WHERE state = 'DROP'': pq: referenced descriptor ID 109: looking up ID 109: descriptor not found
    --- FAIL: TestExtractIngestExternalCatalog/basic (2.93s)

Parameters:

  • attempt=1
  • race=true
  • run=2
  • shard=1
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

msbutler added a commit to msbutler/cockroach that referenced this issue Jan 13, 2025
@msbutler
sql/externalcatalog: deflake TestExtractIngestExternalCatalog
801a3bd 
Fixes cockroachdb#138639

Release note: none
@msbutler msbutler mentioned this issue Jan 13, 2025
Merged
@exalate-issue-sync exalate-issue-sync bot added the P-2 Issues/test failures with a fix SLA of 3 months label Jan 13, 2025
craig bot pushed a commit that referenced this issue Jan 13, 2025
@DrewKimball @msbutler
Merge #138359 #138928
136bd12 
138359: opt: optimize func dep calculations for tables with many indexes r=mgartner a=DrewKimball

#### props: add fast path for ReduceCols

This commit adds a fast path to `FuncDepSet.ReduceCols`. If the FD set has
a strict key and the key is a subset of the given columns, the columns are
immediately reduced just to the key columns. From that point the columns may
be further reduced if the set has been updated since the key was originally
calculated. Note that changes had to be made to `MakeProduct` and `MakeApply`
to ensure that the original key was invalidated before new dependencies were
added to the set.

Epic: None

Release note: None

#### opt: optimize table func deps for non-unique indexes

When a table is referenced in a query, we build a func-dep set describing
the relationships between the table columns. Among other things, we use
the index key columns for this purpose. There is no benefit considering
non-unique indexes here, so this commit skips them to avoid the extra work.
This results in a performance improvement for queries against tables with
many non-unique indexes and many columns.

Epic: None

Release note: None

138928: sql/externalcatalog: deflake TestExtractIngestExternalCatalog r=jeffswenson a=msbutler

Previoulsy, the test would always set sql.gc_job.wait_for_gc.interval to 250
ms, to speed up gc of a dropped table. Occasionally, the gc process would
complete so quickly that this post drop query would return no results, flaking
the test:
`SELECT name FROM crdb_internal.tables WHERE state = 'DROP'`

This patch introduce to branches this test can take:
- with fast gc, to test that the gc job was properly created
- without fast gc, to test that the dropped descriptors end up in the dropped
  state.

Fixes #138639

Release note: none

Co-authored-by: Drew Kimball <drewk@cockroachlabs.com>
Co-authored-by: Michael Butler <butler@cockroachlabs.com>
@craig craig bot closed this as completed in cc5e53e Jan 13, 2025
mohini-crl pushed a commit to mohini-crl/cockroach that referenced this issue Jan 17, 2025
@msbutler
sql/externalcatalog: deflake TestExtractIngestExternalCatalog
4a222fe 
Previoulsy, the test would always set sql.gc_job.wait_for_gc.interval to 250
ms, to speed up gc of a dropped table. Occasionally, the gc process would
complete so quickly that this post drop query would return no results, flaking
the test:
`SELECT name FROM crdb_internal.tables WHERE state = 'DROP'`

This patch introduce to branches this test can take:
- with fast gc, to test that the gc job was properly created
- without fast gc, to test that the dropped descriptors end up in the dropped
  state.

Fixes cockroachdb#138639

Release note: none
@mohini-crl mohini-crl mentioned this issue Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msbutler msbutler

Labels
A-disaster-recovery branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-2 Issues/test failures with a fix SLA of 3 months T-disaster-recovery
Projects
None yet
Milestone
No milestone
2 participants
@cockroach-teamcity @msbutler