New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code and video mismatch #69

Open

yww325 opened this issue Mar 30, 2020 · 0 comments

yww325 commented Mar 30, 2020 •

edited

Loading

in the code https://github.com/codecraft-tv/angular-course/blob/current/5.built-in-directives/2.ngfor/code/src/main.ts#L40
*ngfor is on ul element for GroupByCountry example, and <li> is only wrapping the country name. there is an extra empty line after the inner ul displayed., which is after each country. (I don't know why <ul> element has to have an extra line though, can you show me?)

However, in the video https://codecraft.tv/courses/angular/built-in-directives/ngfor/
the *ngfor is on li element and the inner ul element is wrapped as part of the <li>
there is no extra empty line between each <li>, or say each country.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment