Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to add a placeholder instead of initial number? #13

Open
phlex89 opened this issue Aug 19, 2016 · 4 comments
Open

How to add a placeholder instead of initial number? #13

phlex89 opened this issue Aug 19, 2016 · 4 comments
Labels

Comments

@phlex89
Copy link

phlex89 commented Aug 19, 2016

I would like to use a placeholder in input instead of number 0 by default.

@phlex89
Copy link
Author

phlex89 commented Aug 19, 2016

I temporally resolved passing a new parameter (placeholder: "@?placeholder",) to the directive and changing:
if (isNull($scope.start)) $scope.start = $scope.min;
to
if (isNull($scope.start)) $scope.start = $scope.placeholder;

@cohenadair
Copy link
Owner

cohenadair commented Sep 22, 2016

Sorry for the late reply; I don't actually get notified when an issue is created.

Your solution seems like a reasonable one; I will implement it as soon as I can. Thanks for sharing!

E: In your case, I'm assuming you wanted to show a text placeholder, not a number?

@phlex89
Copy link
Author

phlex89 commented Sep 22, 2016

Yes it was my obj.

Now i'm not using this directive anymore (my customer changed the project).

Thanks anyway.

@phlex89 phlex89 closed this as completed Sep 22, 2016
@cohenadair
Copy link
Owner

No problem. I like the idea, though so I'd like to keep this issue open for now.

@cohenadair cohenadair reopened this Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants