Build for OSX

[hadim]

I don't know what it would take but I would be interested in having an OSX package for ray.

[h-vetinari]

Let's open a PR and find out!
@vnlitvinov tried in the staged-recipes PR but eventually couldn't progress anymore due to lack of an OSX machine.

[hadim]

Thanks @h-vetinari . The thing is I am also lacking an osx machine (I need that build but not for me). So my help will be limited using CI for that.

[vnlitvinov]

For future reference, here's how it failed in CI:

ERROR: /Users/runner/miniforge3/conda-bld/ray-packages_1605888235993/work/b-o/external/com_google_protobuf/BUILD:405:10: Linking of rule '@com_google_protobuf//:protoc' failed (Exit 1): cc_wrapper.sh failed: error executing command 
  (cd /Users/runner/miniforge3/conda-bld/ray-packages_1605888235993/work/b-o/sandbox/darwin-sandbox/260/execroot/com_github_ray_project_ray && \
  exec env - \
    APPLE_SDK_PLATFORM=MacOSX \
    APPLE_SDK_VERSION_OVERRIDE=10.9 \
    PATH=/Users/runner/miniforge3/conda-bld/ray-packages_1605888235993/_build_env/bin:/Users/runner/miniforge3/conda-bld/ray-packages_1605888235993/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/bin:/Users/runner/miniforge3/condabin:/Users/runner/miniforge3/bin:/Users/runner/miniforge3/condabin:/usr/local/opt/pipx_bin:/Users/runner/.cargo/bin:/usr/local/lib/ruby/gems/2.7.0/bin:/usr/local/opt/ruby/bin:/usr/local/opt/curl/bin:/usr/local/bin:/usr/local/sbin:/Users/runner/bin:/Users/runner/.yarn/bin:/usr/local/go/bin:/Users/runner/Library/Android/sdk/tools:/Users/runner/Library/Android/sdk/platform-tools:/Users/runner/Library/Android/sdk/ndk-bundle:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/usr/bin:/bin:/usr/sbin:/sbin:/Users/runner/.dotnet/tools:/Users/runner/.ghcup/bin:/Users/runner/hostedtoolcache/stack/2.5.1/x64 \
    XCODE_VERSION_OVERRIDE=12.0.1.12A7300 \
  external/local_config_cc/cc_wrapper.sh -lc++ -fobjc-link-runtime -Wl,-S -o bazel-out/host/bin/external/com_google_protobuf/protoc bazel-out/host/bin/external/com_google_protobuf/_objs/protoc/main.o bazel-out/host/bin/external/com_google_protobuf/libprotoc_lib.a bazel-out/host/bin/external/com_google_protobuf/libprotobuf.a bazel-out/host/bin/external/com_google_protobuf/libprotobuf_lite.a bazel-out/host/bin/external/zlib/libzlib.a -headerpad_max_install_names -lpthread -lm -lpthread -lm -lpthread -lm -lpthread -lm -no-canonical-prefixes '-mmacosx-version-min=10.9')
Execution platform: @local_config_platform//:host

Use --sandbox_debug to see verbose messages from the sandbox cc_wrapper.sh failed: error executing command 
  (cd /Users/runner/miniforge3/conda-bld/ray-packages_1605888235993/work/b-o/sandbox/darwin-sandbox/260/execroot/com_github_ray_project_ray && \
  exec env - \
    APPLE_SDK_PLATFORM=MacOSX \
    APPLE_SDK_VERSION_OVERRIDE=10.9 \
    PATH=/Users/runner/miniforge3/conda-bld/ray-packages_1605888235993/_build_env/bin:/Users/runner/miniforge3/conda-bld/ray-packages_1605888235993/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/bin:/Users/runner/miniforge3/condabin:/Users/runner/miniforge3/bin:/Users/runner/miniforge3/condabin:/usr/local/opt/pipx_bin:/Users/runner/.cargo/bin:/usr/local/lib/ruby/gems/2.7.0/bin:/usr/local/opt/ruby/bin:/usr/local/opt/curl/bin:/usr/local/bin:/usr/local/sbin:/Users/runner/bin:/Users/runner/.yarn/bin:/usr/local/go/bin:/Users/runner/Library/Android/sdk/tools:/Users/runner/Library/Android/sdk/platform-tools:/Users/runner/Library/Android/sdk/ndk-bundle:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/usr/bin:/bin:/usr/sbin:/sbin:/Users/runner/.dotnet/tools:/Users/runner/.ghcup/bin:/Users/runner/hostedtoolcache/stack/2.5.1/x64 \
    XCODE_VERSION_OVERRIDE=12.0.1.12A7300 \
  external/local_config_cc/cc_wrapper.sh -lc++ -fobjc-link-runtime -Wl,-S -o bazel-out/host/bin/external/com_google_protobuf/protoc bazel-out/host/bin/external/com_google_protobuf/_objs/protoc/main.o bazel-out/host/bin/external/com_google_protobuf/libprotoc_lib.a bazel-out/host/bin/external/com_google_protobuf/libprotobuf.a bazel-out/host/bin/external/com_google_protobuf/libprotobuf_lite.a bazel-out/host/bin/external/zlib/libzlib.a -headerpad_max_install_names -lpthread -lm -lpthread -lm -lpthread -lm -lpthread -lm -no-canonical-prefixes '-mmacosx-version-min=10.9')
Execution platform: @local_config_platform//:host

Use --sandbox_debug to see verbose messages from the sandbox
Undefined symbols for architecture x86_64:
  "_objc_loadClassref", referenced from:
      __ARCLite__load() in libarclite_macosx.a(arclite.o)
  "_objc_readClassPair", referenced from:
      __ARCLite__load() in libarclite_macosx.a(arclite.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Target //:ray_pkg failed to build

[brey]

Hi All.

According to this https://trac.macports.org/ticket/59651 setting APPLE_SDK_VERSION_OVERRIDE=10.11 should work.

[h-vetinari]

Thanks @brey. This can be done by setting

+MACOSX_DEPLOYMENT_TARGET:  # [osx and x86_64]
+  - '10.11'                # [osx and x86_64]
+macos_min_version:         # [osx and x86_64]
+  - '10.11'                # [osx and x86_64]

in recipe/conda_build_config.yaml (which will need to be created), cf. e.g. here. And then rerendering the feedstock. Does someone want to open a PR?

[pyrito]

Hi all, is there any progress on this effort? This is starting to become a bit of a blocker for Modin.

[mattip]

I made more progress in #77 but it seems the minumum version supported by ray is macos 10.15. Is this acceptable?

[pyrito]

@mattip I think that should be acceptable

[timkpaine]

#119