Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bazel pins #34

Closed
h-vetinari opened this issue Aug 12, 2021 · 4 comments
Closed

Bazel pins #34

h-vetinari opened this issue Aug 12, 2021 · 4 comments

Comments

@h-vetinari
Copy link
Member

I just wanted to check upstream what the currently pinned/approved bazel version is, but since it is at 3.2.0, our pinning already violates that.

So why are we pinning bazel at all? @krfricke @vnlitvinov
Cf. some issues in #21.
@vnlitvinov
Copy link
Contributor

I have somehow missed that... Current pinning in the conda recipe was found by trial and error because some more recent Bazel versions failed the build. I do not know what's the current situation, though.

@krfricke
Copy link
Contributor

I have to update the feedstock for upcoming Ray 1.7 next week anyway as we upstreamed some of the patches. I can check Bazel version compatibility then, too

@mattip
Copy link
Contributor

mattip commented Oct 20, 2022

I think this should be closed.

@mattip
Copy link
Contributor

mattip commented Jan 15, 2024

Closing. bazel is pinned like upstream now to 5.4.1

@mattip mattip closed this as completed Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mattip @krfricke @h-vetinari @vnlitvinov