-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider additional measures for reproducible builds #1
Comments
Thanks for re-raising these. Some of them can be here, others that deal more with the metadata contents and generation of pyc files will need to be in conda-build. The collection, for reference, is at https://github.com/conda/conda-build/labels/reproducibility The ones I think we can do something about here are:
|
To be clear, this package has absolutely nothing to do with generating pyc files. I'm trying to keep the separation of concerns stronger. This library is strictly about packing stuff up and unpacking it. Removing timestamp and user info might be admissible, but pyc is definitely more than I want in here. The file sorting is exactly the right kind of thing for this package. |
👍 to separation of concerns. Cool label! My point with the
Carry on, sir! |
Hi there, thank you for your contribution! This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs. If you would like this issue to remain open please:
NOTE: If this issue was closed prematurely, please leave a comment. Thanks! |
The new format sounds like it makes great strides for performance. The other end of moving the package landscape forward is taking any possible opportunities to increase the bit-for-bit reproducibility of the resulting artifacts.
A number of the measures in conda/conda-build#2140 were introduced at various stages, but there are still places where strange paths and file stamps get injected. Especially with the enhanced reproducibility of
pyc
in Python 3.7, this would be a great opportunity to look again at some of these issues.Keep up the good work!
The text was updated successfully, but these errors were encountered: