Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider additional measures for reproducible builds #1

Closed
bollwyvl opened this issue Jan 6, 2019 · 4 comments
Closed

Consider additional measures for reproducible builds #1

bollwyvl opened this issue Jan 6, 2019 · 4 comments
Labels
locked [bot] locked due to inactivity stale::closed [bot] closed after being marked as stale stale [bot] marked as stale due to inactivity

Comments

@bollwyvl
Copy link

bollwyvl commented Jan 6, 2019

The new format sounds like it makes great strides for performance. The other end of moving the package landscape forward is taking any possible opportunities to increase the bit-for-bit reproducibility of the resulting artifacts.

A number of the measures in conda/conda-build#2140 were introduced at various stages, but there are still places where strange paths and file stamps get injected. Especially with the enhanced reproducibility of pyc in Python 3.7, this would be a great opportunity to look again at some of these issues.

Keep up the good work!

@msarahan
Copy link
Contributor

msarahan commented Jan 6, 2019

Thanks for re-raising these. Some of them can be here, others that deal more with the metadata contents and generation of pyc files will need to be in conda-build.

The collection, for reference, is at https://github.com/conda/conda-build/labels/reproducibility

The ones I think we can do something about here are:

@msarahan
Copy link
Contributor

msarahan commented Jan 6, 2019

To be clear, this package has absolutely nothing to do with generating pyc files. I'm trying to keep the separation of concerns stronger. This library is strictly about packing stuff up and unpacking it. Removing timestamp and user info might be admissible, but pyc is definitely more than I want in here. The file sorting is exactly the right kind of thing for this package.

@bollwyvl
Copy link
Author

bollwyvl commented Jan 6, 2019

👍 to separation of concerns. Cool label! My point with the pycs is that it was inconvenient to hit predictable builds for many of the python packages before, is easier now, and that this library shouldn't make anything worse.

.conda format should aspirationally (maybe with post-processing) be able to be verifiably reproducible, and eventually tracked and preferred.

Carry on, sir!

jjhelmus pushed a commit to jjhelmus/conda-package-handling that referenced this issue Sep 19, 2019
@github-actions
Copy link

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    - What OS and version you reproduced the issue on
    - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Mar 31, 2022
@github-actions github-actions bot added the stale::closed [bot] closed after being marked as stale label May 14, 2022
@github-actions github-actions bot moved this to Done in 🧭 Planning May 14, 2022
@github-actions github-actions bot added the locked [bot] locked due to inactivity label May 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity stale::closed [bot] closed after being marked as stale stale [bot] marked as stale due to inactivity
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants