diff --git a/gulpfile.js b/gulpfile.js index 55aaa10..7b58279 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -107,7 +107,16 @@ mapappsBrowserSync.registerTask({ npmModules: [ "mocha", "chai", - "@conterra/mapapps-mocha-runner" + "@conterra/mapapps-mocha-runner", + [ + "@vue/test-utils", + { + // need to overwrite main to load it into the browser + main: "dist/vue-test-utils.umd" + } + ], + // required as peer dependency of @vue/test-utils + "vue-template-compiler" ] }, // prevent reload by browser sync (reload triggered on watch end) diff --git a/package.json b/package.json index af3b813..8e3636d 100644 --- a/package.json +++ b/package.json @@ -12,6 +12,7 @@ "chai": "4.3.10", "ct-mapapps-browser-sync": "0.0.35", "ct-mapapps-gulp-js": "0.10.2", + "dompurify": "~3.1.0", "eslint-config-ct-prodeng": "1.4.0", "license-checker": "25.0.1", "mocha": "10.2.0", @@ -24,6 +25,7 @@ "tsx": "^4.6.0", "typescript": "5.2.2", "vue": "2.7.15", - "vue-template-compiler": "2.7.15" + "vue-template-compiler": "2.7.15", + "@vue/test-utils": "1.3.5" } } diff --git a/src/main/js/apps/sample/app.json b/src/main/js/apps/sample/app.json index ffa168a..bf1e426 100644 --- a/src/main/js/apps/sample/app.json +++ b/src/main/js/apps/sample/app.json @@ -24,9 +24,6 @@ "toolset", "dn_welcome" ], - "require": [ - "${app}/app" - ], "i18n": [ "bundle" ] @@ -38,9 +35,9 @@ "infoText": "${welcome.infoText}", "showButton": true, "buttonText": "${welcome.buttonText}", - "buttonDependsOnCheckbox": true, + "buttonDependsOnCheckbox": false, "showCheckbox": true, - "checkboxChecked": true, + "checkboxChecked": false, "checkboxText": "${welcome.checkboxText}", "showImage": true, "imageHeight": "300px", diff --git a/src/main/js/apps/sample/external-test-resources/infotext-with-heading.html b/src/main/js/apps/sample/external-test-resources/infotext-with-heading.html new file mode 100644 index 0000000..94cb271 --- /dev/null +++ b/src/main/js/apps/sample/external-test-resources/infotext-with-heading.html @@ -0,0 +1,6 @@ + +
+Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum.
+ + diff --git a/src/main/js/apps/sample/external-test-resources/infotext.html b/src/main/js/apps/sample/external-test-resources/infotext.html new file mode 100644 index 0000000..8936469 --- /dev/null +++ b/src/main/js/apps/sample/external-test-resources/infotext.html @@ -0,0 +1,5 @@ + + +Welcome IFrame
+ + diff --git a/src/main/js/apps/sample/external-test-resources/infotext.txt b/src/main/js/apps/sample/external-test-resources/infotext.txt new file mode 100644 index 0000000..d5b2be6 --- /dev/null +++ b/src/main/js/apps/sample/external-test-resources/infotext.txt @@ -0,0 +1 @@ +This is an external resource that is embedded into an iframe. diff --git a/src/main/js/bundles/dn_welcome/README.md b/src/main/js/bundles/dn_welcome/README.md index 0dd965c..56efce9 100644 --- a/src/main/js/bundles/dn_welcome/README.md +++ b/src/main/js/bundles/dn_welcome/README.md @@ -19,6 +19,7 @@ All configuration is performed on the `Config` component as show in the followin "Config": { "heading": "${welcome.heading}", "infoText": "${welcome.infoText}", + "infoTextUrl": "", "showButton": true, "buttonText": "${welcome.buttonText}", "buttonDependsOnCheckbox": true, @@ -27,27 +28,64 @@ All configuration is performed on the `Config` component as show in the followin "checkboxChecked": true, "showImage": true, "imageUrl": "resource('${app}:images/welcome.jpg')", - "imageHeight": "300px" + "imageHeight": "300px" } } } ``` + +### Including external resources + +In some cases, it is helpful to be able to include text or an image from an external location. +For example, if the info text in the dialog changes frequently, it may be easier to include the text from an external HTML file. +The file can then be edited by the responsible people without requiring access to the map.apps Manager. +Including the info text from an HTML file also allows for a much more sophisticated layout, if you include CSS. + +To do this, create an HTML file on a publicly accessible web server. The file should look something like this: + +````html + + +Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua.
+ + +```` + +In your `app.json`, configure the `infoTextUrl` property to the URL of that HTML file: + +````json +{ + "dn_welcome": { + "Config": { + "infoTextUrl": "https://www.example.com/resources/infotext.html" + } + } +} +```` + +The HTML file is then embedded within an Iframe in the welcome dialog. + +The same is possible for images at the top of the dialog. +Simply set the `imageUrl` to the URL of an external image, e.g. https://www.example.com/resources/myimage.jpg + #### Available properties All of these properties are optional. -| Property | Type | Possible values | Default | Description | -|--------------|---------|-----------------------|---------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| -| `heading` | String | | | The heading shown below the image. | -| `infoText` | String | | | The text displayed in the main content area of the window. | -| `showButton` | Boolean | `true` | `false` | `true` | Whether to show the button. If you still require a way to close the windo without using the button, you can remove `noTitleBarAndWindowTools` CSS class from the window's `windowClass` property. The window title bar containing a "close" button will then become visible. See the [templates bundle documentation](https://demos.conterra.de/mapapps/resources/jsregistry/root/templates/latest/README.md#b%3Dtemplates%3Bv%3D4.17.0%3Bf%3Dtempla%3B) for more information. | -| `buttonText` | String | | | The label of the button. | +| Property | Type | Possible values | Default | Description | +|---------------------------|---------|-------------------------|-------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| +| `heading` | String | | | The heading shown below the image. If this property is set to an empty | +| `infoText` | String | | | The text displayed in the main content area of the window. | +| `infoTextUrl` | String | | | The URL to an external HTML document that should be embedded in an iframe as info text. If this property is left empty, the iframe will not be shown. | +| `showButton` | Boolean | `true` | `false` | `true` | Whether to show the button. If you still require a way to close the windo without using the button, you can remove `noTitleBarAndWindowTools` CSS class from the window's `windowClass` property. The window title bar containing a "close" button will then become visible. See the [templates bundle documentation](https://demos.conterra.de/mapapps/resources/jsregistry/root/templates/latest/README.md#b%3Dtemplates%3Bv%3D4.17.0%3Bf%3Dtempla%3B) for more information. | +| `buttonText` | String | | | The label of the button. | | `buttonDependsOnCheckbox` | Boolean | `true` | `false` | `false` | If `true`, the button is only enabled when the checkbox is checked. If the checkbox is not checked, the button is greyed out and cannot be clicked. Note: `showCheckbox` must be `true` for this property to have an effect. | `showCheckbox` | Boolean | `true` | `false` | `true` | Whether to show the checkbox in the window. Note: The property `buttonDependsOnCheckbox` is ignored, if `showCheckbox` is `false`. | | `checkboxText` | String | | | The label for the checkbox. | | `checkboxChecked` | Boolean | `true` | `false` | `false` | Whether the checkbox is already checked when the welcome window shows up. | | `showImage` | Boolean | `true` | `false` | `true` | Whether to show an image at the top of the welcome window. | -| `imageUrl` | String | | | The URL to the image shown at the top of the welcome window. Besides absolute URLs, you can use a relative URL to address an image inside the app folder: `resource('${app}:images/welcome.jpg')` | +| `imageUrl` | String | | | The URL to the image shown at the top of the welcome window. Besides absolute URLs, you can use a relative URL to address an image inside the app folder: `resource('${app}:images/welcome.jpg')` | | `imageHeight` | String | | ```300px``` | The height of the image defined as a valid CSS dimension string. | diff --git a/src/main/js/bundles/dn_welcome/WelcomeWidget.ts.vue b/src/main/js/bundles/dn_welcome/WelcomeWidget.ts.vue index f2b5d24..381f1ea 100644 --- a/src/main/js/bundles/dn_welcome/WelcomeWidget.ts.vue +++ b/src/main/js/bundles/dn_welcome/WelcomeWidget.ts.vue @@ -16,27 +16,41 @@ --> -Click here!
", + shouldNotInclude: "onclick" + }, + { + message: "'script' tags should be removed from info text", + testInfoText: "Welcome! ", + shouldNotInclude: "script" + }, + { + message: "Uppercase 'SCRIPT' tags should be removed from info text", + testInfoText: "Welcome! ", + shouldNotInclude: "SCRIPT" + }, + { + message: "'iframe' tags should be removed from info text", + testInfoText: "Welcome! ", + shouldNotInclude: "iframe" + }, + { + message: "'object' tags should be removed from info text", + testInfoText: "Welcome! ", + shouldNotInclude: "object" + }, + { + message: "'embed' tags should be removed from info text", + testInfoText: "Welcome! ", + shouldNotInclude: "embed" + }, + { + message: "'i' tags should be preserved in info text", + testInfoText: "Welcome!", + shouldInclude: "" + }, + { + message: "'style' attributes on tags should be preserved in info text", + testInfoText: "Welcome
", + shouldInclude: "style" + } + ] as SanitizerTestCase[]; + + sanitizerTests.forEach(testCase => { + it(testCase.message, async function () { + const wrapper = mount(WelcomeWidget); + await wrapper.setData({ + infoText: testCase.testInfoText + }); + const infoTextWrapper = wrapper.find(".dn-welcome-widget__info-text"); + + const html = infoTextWrapper.html(); + + if (testCase.shouldNotInclude) { + assert.notInclude(html, testCase.shouldNotInclude); + } + if (testCase.shouldInclude) { + assert.include(html, testCase.shouldInclude); + } + }); + }); +}); + +interface SanitizerTestCase { + message: string; + testInfoText: string; + shouldNotInclude?: string; + shouldInclude?: string; +} diff --git a/src/main/js/bundles/dn_welcome/tests/all.js b/src/main/js/bundles/dn_welcome/tests/all.js index 3e84a4d..3342d22 100644 --- a/src/main/js/bundles/dn_welcome/tests/all.js +++ b/src/main/js/bundles/dn_welcome/tests/all.js @@ -13,3 +13,4 @@ * See the License for the specific language governing permissions and * limitations under the License. */ +import "./WelcomeWidgetTest"; diff --git a/src/main/js/bundles/dn_welcome/tests/test-modules.d.ts b/src/main/js/bundles/dn_welcome/tests/test-modules.d.ts new file mode 100644 index 0000000..0523969 --- /dev/null +++ b/src/main/js/bundles/dn_welcome/tests/test-modules.d.ts @@ -0,0 +1,20 @@ +/// +/// Copyright (C) 2024 con terra GmbH (info@conterra.de) +/// +/// Licensed under the Apache License, Version 2.0 (the "License"); +/// you may not use this file except in compliance with the License. +/// You may obtain a copy of the License at +/// +/// http://www.apache.org/licenses/LICENSE-2.0 +/// +/// Unless required by applicable law or agreed to in writing, software +/// distributed under the License is distributed on an "AS IS" BASIS, +/// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +/// See the License for the specific language governing permissions and +/// limitations under the License. +/// + +declare module "module" { + export const id: string; +} +declare module "require"; diff --git a/src/main/js/bundles/dompurify-bundle/LICENSE b/src/main/js/bundles/dompurify-bundle/LICENSE new file mode 100644 index 0000000..00a8108 --- /dev/null +++ b/src/main/js/bundles/dompurify-bundle/LICENSE @@ -0,0 +1,231 @@ +Apache License +Version 2.0, January 2004 +http://www.apache.org/licenses/ + +TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + +1. Definitions. + +"License" shall mean the terms and conditions for use, reproduction, +and distribution as defined by Sections 1 through 9 of this document. + +"Licensor" shall mean the copyright owner or entity authorized by +the copyright owner that is granting the License. + +"Legal Entity" shall mean the union of the acting entity and all +other entities that control, are controlled by, or are under common +control with that entity. For the purposes of this definition, +"control" means (i) the power, direct or indirect, to cause the +direction or management of such entity, whether by contract or +otherwise, or (ii) ownership of fifty percent (50%) or more of the +outstanding shares, or (iii) beneficial ownership of such entity. + +"You" (or "Your") shall mean an individual or Legal Entity +exercising permissions granted by this License. + +"Source" form shall mean the preferred form for making modifications, +including but not limited to software source code, documentation +source, and configuration files. + +"Object" form shall mean any form resulting from mechanical +transformation or translation of a Source form, including but +not limited to compiled object code, generated documentation, +and conversions to other media types. + +"Work" shall mean the work of authorship, whether in Source or +Object form, made available under the License, as indicated by a +copyright notice that is included in or attached to the work +(an example is provided in the Appendix below). + +"Derivative Works" shall mean any work, whether in Source or Object +form, that is based on (or derived from) the Work and for which the +editorial revisions, annotations, elaborations, or other modifications +represent, as a whole, an original work of authorship. For the purposes +of this License, Derivative Works shall not include works that remain +separable from, or merely link (or bind by name) to the interfaces of, +the Work and Derivative Works thereof. + +"Contribution" shall mean any work of authorship, including +the original version of the Work and any modifications or additions +to that Work or Derivative Works thereof, that is intentionally +submitted to Licensor for inclusion in the Work by the copyright owner +or by an individual or Legal Entity authorized to submit on behalf of +the copyright owner. For the purposes of this definition, "submitted" +means any form of electronic, verbal, or written communication sent +to the Licensor or its representatives, including but not limited to +communication on electronic mailing lists, source code control systems, +and issue tracking systems that are managed by, or on behalf of, the +Licensor for the purpose of discussing and improving the Work, but +excluding communication that is conspicuously marked or otherwise +designated in writing by the copyright owner as "Not a Contribution." + +"Contributor" shall mean Licensor and any individual or Legal Entity +on behalf of whom a Contribution has been received by Licensor and +subsequently incorporated within the Work. + +2. Grant of Copyright License. Subject to the terms and conditions of +this License, each Contributor hereby grants to You a perpetual, +worldwide, non-exclusive, no-charge, royalty-free, irrevocable +copyright license to reproduce, prepare Derivative Works of, +publicly display, publicly perform, sublicense, and distribute the +Work and such Derivative Works in Source or Object form. + +3. Grant of Patent License. Subject to the terms and conditions of +this License, each Contributor hereby grants to You a perpetual, +worldwide, non-exclusive, no-charge, royalty-free, irrevocable +(except as stated in this section) patent license to make, have made, +use, offer to sell, sell, import, and otherwise transfer the Work, +where such license applies only to those patent claims licensable +by such Contributor that are necessarily infringed by their +Contribution(s) alone or by combination of their Contribution(s) +with the Work to which such Contribution(s) was submitted. If You +institute patent litigation against any entity (including a +cross-claim or counterclaim in a lawsuit) alleging that the Work +or a Contribution incorporated within the Work constitutes direct +or contributory patent infringement, then any patent licenses +granted to You under this License for that Work shall terminate +as of the date such litigation is filed. + +4. Redistribution. You may reproduce and distribute copies of the +Work or Derivative Works thereof in any medium, with or without +modifications, and in Source or Object form, provided that You +meet the following conditions: + +(a) You must give any other recipients of the Work or +Derivative Works a copy of this License; and + +(b) You must cause any modified files to carry prominent notices +stating that You changed the files; and + +(c) You must retain, in the Source form of any Derivative Works +that You distribute, all copyright, patent, trademark, and +attribution notices from the Source form of the Work, +excluding those notices that do not pertain to any part of +the Derivative Works; and + +(d) If the Work includes a "NOTICE" text file as part of its +distribution, then any Derivative Works that You distribute must +include a readable copy of the attribution notices contained +within such NOTICE file, excluding those notices that do not +pertain to any part of the Derivative Works, in at least one +of the following places: within a NOTICE text file distributed +as part of the Derivative Works; within the Source form or +documentation, if provided along with the Derivative Works; or, +within a display generated by the Derivative Works, if and +wherever such third-party notices normally appear. The contents +of the NOTICE file are for informational purposes only and +do not modify the License. You may add Your own attribution +notices within Derivative Works that You distribute, alongside +or as an addendum to the NOTICE text from the Work, provided +that such additional attribution notices cannot be construed +as modifying the License. + +You may add Your own copyright statement to Your modifications and +may provide additional or different license terms and conditions +for use, reproduction, or distribution of Your modifications, or +for any such Derivative Works as a whole, provided Your use, +reproduction, and distribution of the Work otherwise complies with +the conditions stated in this License. + +5. Submission of Contributions. Unless You explicitly state otherwise, +any Contribution intentionally submitted for inclusion in the Work +by You to the Licensor shall be under the terms and conditions of +this License, without any additional terms or conditions. +Notwithstanding the above, nothing herein shall supersede or modify +the terms of any separate license agreement you may have executed +with Licensor regarding such Contributions. + +6. Trademarks. This License does not grant permission to use the trade +names, trademarks, service marks, or product names of the Licensor, +except as required for reasonable and customary use in describing the +origin of the Work and reproducing the content of the NOTICE file. + +7. Disclaimer of Warranty. Unless required by applicable law or +agreed to in writing, Licensor provides the Work (and each +Contributor provides its Contributions) on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or +implied, including, without limitation, any warranties or conditions +of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A +PARTICULAR PURPOSE. You are solely responsible for determining the +appropriateness of using or redistributing the Work and assume any +risks associated with Your exercise of permissions under this License. + +8. Limitation of Liability. In no event and under no legal theory, +whether in tort (including negligence), contract, or otherwise, +unless required by applicable law (such as deliberate and grossly +negligent acts) or agreed to in writing, shall any Contributor be +liable to You for damages, including any direct, indirect, special, +incidental, or consequential damages of any character arising as a +result of this License or out of the use or inability to use the +Work (including but not limited to damages for loss of goodwill, +work stoppage, computer failure or malfunction, or any and all +other commercial damages or losses), even if such Contributor +has been advised of the possibility of such damages. + +9. Accepting Warranty or Additional Liability. While redistributing +the Work or Derivative Works thereof, You may choose to offer, +and charge a fee for, acceptance of support, warranty, indemnity, +or other liability obligations and/or rights consistent with this +License. However, in accepting such obligations, You may act only +on Your own behalf and on Your sole responsibility, not on behalf +of any other Contributor, and only if You agree to indemnify, +defend, and hold each Contributor harmless for any liability +incurred by, or claims asserted against, such Contributor by reason +of your accepting any such warranty or additional liability. + +END OF TERMS AND CONDITIONS + +APPENDIX: How to apply the Apache License to your work. + +To apply the Apache License to your work, attach the following +boilerplate notice, with the fields enclosed by brackets "{}" +replaced with your own identifying information. (Don't include +the brackets!) The text should be enclosed in the appropriate +comment syntax for the file format. We also recommend that a +file or class name and description of purpose be included on the +same "printed page" as the copyright notice for easier +identification within third-party archives. + +Copyright Esri 2020 + +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + +http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. + +----------------------------------------------------------------- + +js-xss/ + +/* + Copyright (c) 2012-2017 Zongmin Lei(雷宗民)