Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiplier does not apply form rules #79

Open
radekdostal opened this issue Jan 24, 2023 · 2 comments
Open

Multiplier does not apply form rules #79

radekdostal opened this issue Jan 24, 2023 · 2 comments

Comments

@radekdostal
Copy link

radekdostal commented Jan 24, 2023

Tested with version 3.2.0.

$budgets = $form->addMultiplier('budgets', function(Container $budget, Form $form): void
{
  $budget->addText('price', 'Cena')
    ->setMaxLength(10)
    ->setRequired()
    ->addRule($form::FLOAT)
    ->addRule($form::MIN, NULL, 1);
});

E.g. for the value "10 000,00" the conversion to type float is not applied.

The same for the filter. The code inside the function is not called at all.

...
->addFilter(function ($value) {
  return str_replace([' ', ','], ['', '.'], $value)
})
...

Outside of the multiplier, the value is correctly converted to a float.

I think it is due to this:
https://github.com/contributte/forms-multiplier/blob/v3.2.0/src/Multiplier.php#L206

It is fixed in version 3.3.0:
https://github.com/contributte/forms-multiplier/blob/v3.3.0/src/Multiplier.php#L206

Could you please release a new version 3.2.1? Unfortunately I can't switch to Latte 3 yet. Thank you very much.

Related to:
#68
#69

@jtojnar
Copy link
Collaborator

jtojnar commented Mar 20, 2024

Hi. Do you still need 3.2.1?

@radekdostal
Copy link
Author

Hi, it would be nice. I have manually fixed it in some applications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants