Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAProxy Version handling #160

Open
superstes opened this issue Jan 5, 2025 · 1 comment
Open

HAProxy Version handling #160

superstes opened this issue Jan 5, 2025 · 1 comment

Comments

@superstes
Copy link

superstes commented Jan 5, 2025

While I've worked on #159 I've seen that the tests currently only target one HAProxy version.
Also - the tested version is not the same as in the example.

This is especially interesting for versions like 3.1 where there were changes to the SPOE implementation.

It might make sense to use the action-matrix to run tests on multiple versions. (all currently supported ones?)
We would need to pass the current version to the FTW docker-compose to dynamically pull the correct container.

Note: Not sure how long such tests would take. Maybe a nightly workflow like in the caddy repository could make sense for such.

@fionera
Copy link
Contributor

fionera commented Jan 5, 2025

Yes we should use a matrix run for tests and soon ftw. Afaik you can use an env var for selecting the container version which would make it simple to combine with a matrix. Running then in a nightly workflow shouldn't be required as the tests are really fast right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants