Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

Create a requirements.txt to manage dependencies #63

Open
dasmur opened this issue Jun 13, 2020 · 0 comments · May be fixed by #69
Open

Create a requirements.txt to manage dependencies #63

dasmur opened this issue Jun 13, 2020 · 0 comments · May be fixed by #69

Comments

@dasmur
Copy link
Contributor

dasmur commented Jun 13, 2020

This project explicitly (see README.md#requirements) and implicitly (see Dockerfile) documents the dependencies. Because this is done on several locations, sooner or later someone will miss to update the dependencies which will result in inconsistencies.

At the same time, Python provides a straight forward way to specify dependencies, the requirements.txt.
Advantages:

  • Only one location
  • Supported by the toolchain (e.g. pip can directly parse the content)

What do you think about switching to requirements.txt?
dasmur added a commit to dasmur/corona_landkreis_fallzahlen_scraping that referenced this issue Jun 18, 2020
@dasmur
Add a requirements.txt for python dependencies
5e3edf0 
This commit introduces a requirements.txt to define
all dependencies required to build the crawler at one
central point.
The Dockerfile and the documentation will also be adapted
accordingly.

(fixes: corona-zahlen-landkreis#63)
@dasmur dasmur linked a pull request Jun 18, 2020 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a requirements.txt for python dependencies dasmur/corona_landkreis_fallzahlen_scraping
1 participant
@dasmur