Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging in tenanted container factory classes #108

Open
jongeorge1 opened this issue Mar 24, 2020 · 0 comments
Open

Improve logging in tenanted container factory classes #108

jongeorge1 opened this issue Mar 24, 2020 · 0 comments
Assignees

Comments

@jongeorge1
Copy link
Contributor

jongeorge1 commented Mar 24, 2020

When a tenanted container of any type (Cosmos, SQL, Gremlin, Storage) is created, configuration is read from the current tenant, firstly by looking for specific configuration for the container being created (based on the definition of the required container), then by looking for default configuration.

When tenants or applications are misconfigured, the outcome is generally unexpected and unhelpful exceptions. As such we need to dramatically improve the logging code around container creation (without leaking any secrets) so that it's easy to see in AppInsights what configuration is being used and where it points to (e.g. the names of keyvaults, databases, etc).

We also need to ensure we are throwing helpful exceptions when configuration is missing or invalid.

@jongeorge1 jongeorge1 self-assigned this Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant